Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Jan 2019 17:27:45 +0000
From:      bugzilla-noreply@freebsd.org
To:        net@FreeBSD.org
Subject:   [Bug 233535] Fix refcount leak in IPv6 MLD code leading to loss of IPv6 connectivity
Message-ID:  <bug-233535-7501-iobqR6scn4@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-233535-7501@https.bugs.freebsd.org/bugzilla/>
References:  <bug-233535-7501@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233535

Hans Petter Selasky <hselasky@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #201210|0                           |1
        is obsolete|                            |

--- Comment #41 from Hans Petter Selasky <hselasky@FreeBSD.org> ---
Created attachment 201220
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D201220&action=
=3Dedit
Fix MLD refcounting in IPv6 code (including additional debugging).

Hi @ae,

Found one more bug. According to the logs you provided I figured out the inm
leaks when entering mld_v1_process_group_timer() and looking at the version
history this function should not disconnect the inm, only queue a v1_transm=
it.

I've uploaded a new patch. Can you re-test?

Thank you!

--HPS

@@ -1488,8 +1493,7 @@ mld_v1_process_group_timer(struct in6_multi_head *inm=
h,
struct in6_multi *in
m)
        case MLD_REPORTING_MEMBER:
                if (report_timer_expired) {
                        inm->in6m_state =3D MLD_IDLE_MEMBER;
-                       in6m_disconnect(inm);
-                       in6m_rele_locked(inmh, inm);
+                       SLIST_INSERT_HEAD(inmh, inm, in6m_nrele);

--=20
You are receiving this mail because:
You are on the CC list for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233535-7501-iobqR6scn4>