From owner-svn-src-head@freebsd.org Sat Jun 30 17:05:04 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 94D85BB5 for ; Sat, 30 Jun 2018 17:05:04 +0000 (UTC) (envelope-from marklmi@yahoo.com) Received: from sonic306-20.consmr.mail.gq1.yahoo.com (sonic306-20.consmr.mail.gq1.yahoo.com [98.137.68.83]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 150AF84CA1 for ; Sat, 30 Jun 2018 17:05:04 +0000 (UTC) (envelope-from marklmi@yahoo.com) X-YMail-OSG: XeMX4HgVM1lRZ7liL7rVIPGTquJSZscRE5dNnhy9axojtLxx8X1JTq_eNdNzZIu OGlodgEFSXt5UN8ZOBCqGXkdF0mx78sXmjZ2hdhaCoSf1jpIU8Em_T4bnqm4VRvCdxm7r.ecmw2W 0Yx1c78Fl5FC8Bz1BAhEXrlGudgxZGfauKwxQ9ztruUMLot_1xowidWNgrdbtqDJXlFxXjnu8P5r TpW2l67C0hX_gSfABgIqhJ.J2ozGZ07_m2CMWusM5WD5n1AVWdJ8YwbGLI2VOzzPXReKcLyqb.fO ULpfcMCU6A0Ml31JEaFwz8GoZjjBEYhOz64nWZmxZoXdRg7WQDb_5.q4BqAknGBkLc8TehPsGIMs FCdzec3UXcD0qsJAXFarfn4sDNPdk3CYoatfLf8KSiOTeR0vyWPP6ZN7ykGHqpJStgSE4u_N4hS5 q6EJtLLeEbqMD8z9MvfK5EZP0fRh00untUTcT4NwNzyCwfJa4ZAKG7bQKXyf0qb.OykNTThLm2kn Ae.Ac157uuDVfsok6JmlDAUtRL02ZVq7NeSyZ2Ftn7boaBRDnxfHnWqFXQgmSVWnktYun0crLdex UVIqwtCx5qMp8iJUwNIgDqmscEHe0uMVHyogb7X8wjej.u7eYbg38psk4xEJHGl_XnVGNXpSawSM yTfwKHwIyiz8LfLJj8NuMWdP0XDpGT.4wHcVmmeRN8t7zKdL0fcM_ba6s_P5D70._7lTCpz.tO1J z7mSohpuW9mJxyDOPF1YLspiCX.P9YhoOp8.qOmIbeAvDpiBKdxnfiGhyyBEhvJTMbPF388.J3lC n9gT432tgjH0CzJ1879xxq61QDiUAAGUEkeKHer1h_PWaiMPcxTcz2z097r1NSKS7rG1VebLHoml LArxt5fAbqDd7y6kcftDibSoIXJo4MVDUWt6LY6RXDOj4t9nCaqR7svzcyOwAAone3w_2LEp7L31 Gb2Rt6CBfMY4reDFGwRV2pvXSnuSElQV6 Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.gq1.yahoo.com with HTTP; Sat, 30 Jun 2018 17:04:56 +0000 Received: from ip70-189-131-151.lv.lv.cox.net (EHLO [192.168.0.105]) ([70.189.131.151]) by smtp418.mail.gq1.yahoo.com (Oath Hermes SMTP Server) with ESMTPA ID f284a0a421dafd545100c752ffb27663; Sat, 30 Jun 2018 17:04:53 +0000 (UTC) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 11.4 \(3445.8.2\)) Subject: Re: head -r335782 (?) broke ci.freebsd.org's FreeBSD-head-amd64-gcc build (lib32 part of build) From: Mark Millard In-Reply-To: Date: Sat, 30 Jun 2018 10:04:51 -0700 Cc: Dimitry Andric , Bryan Drewery , svn-src-head@freebsd.org, FreeBSD Current Content-Transfer-Encoding: quoted-printable Message-Id: <49BF6569-96A9-4104-BDE6-8BB94C0D9626@yahoo.com> References: <00D1127A-1F0E-4E0E-B86C-1C5AA5B2E085@yahoo.com> <7A845F2C-C994-4828-823D-33A97B7B6EB0@yahoo.com> <72081b02-cf23-82ec-32df-7f5793c35f57@FreeBSD.org> <003509F0-F2F4-4A43-82FE-3F6FC23D19D4@yahoo.com> <65b19cc4-eaf0-13ed-43e6-9f04a1f7f196@FreeBSD.org> To: John Baldwin X-Mailer: Apple Mail (2.3445.8.2) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 Jun 2018 17:05:04 -0000 On 2018-Jun-30, at 9:29 AM, John Baldwin wrote: > On 6/30/18 9:17 AM, Mark Millard wrote: >> On 2018-Jun-30, at 7:51 AM, John Baldwin wrote: >>=20 >>> On 6/29/18 2:37 PM, Mark Millard wrote: >>>> [I expect this is more than just amd64-gcc related but that is all >>>> that ci.freebsd.org normally builds via a devel/*-gcc .] >>>=20 >>> As indicated by my other mail, this is i386 and amd64 specific as it >>> only matters for float.h on i386 due to the disagreement on >>> LDBL_MANT_DIG. >>=20 >> I was correct about the search order for include files being >> different before -r335782 vs. -r335782 and later: >=20 > Yes, but this is kind of a feature, not a bug, and the issue there is = that > as much as possible we should allow FreeBSD to work with the standard = headers > that are supposed to be part of the language (and thus provided by the > toolchain). Right now we don't ship any of the 'std*.h' headers clang > provides for example in our base system clang, though a few months ago = I > fixed the one place that was using instead of > in userland that was breaking the use of the = toolchain-provided > stdarg.h (both GCC and clang). >=20 >> Might this reversal have other effects even for >> architectures for which the code does compile >> via devel/*-gcc ? >=20 > It depends on the header. This particular failure is due to a quirk = of > on FreeBSD/i386. I have built other platforms with external > GCC just fine. To the extent that we encounter any other issues we > should try to make our source more conformant with C and only fall = back to > axeing the toolchain-provided language headers as a last resort. It is too bad that the review https://reviews.freebsd.org/D16055 did not catch the change in what headers are used by buildworld and buildkernel. I'd view such switching of long established header bindings as a fairly big deal, possibly even warranting being explicitly proposed and debated. I'm not claiming my opinion on which search order that I have is actually relevant. I'm just now nervous about my powerpc64-gcc based builds having unexpected differences, for example. [I sometimes explore the status of powerpc family builds via more modern toolchains.] (But lib32 for powerpc64 via modern gcc's is messed up anyway, generating code in crtbeginS.o for the wrong ABI: using R30 incorrectly. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D206123 has more = about that.) =3D=3D=3D Mark Millard marklmi at yahoo.com ( dsl-only.net went away in early 2018-Mar)