From owner-cvs-all Fri Sep 14 2:30:15 2001 Delivered-To: cvs-all@freebsd.org Received: from Awfulhak.org (gw.Awfulhak.org [217.204.245.18]) by hub.freebsd.org (Postfix) with ESMTP id 1F61737B406; Fri, 14 Sep 2001 02:30:01 -0700 (PDT) Received: from hak.lan.Awfulhak.org (root@hak.lan.Awfulhak.org [fec0::1:12]) by Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8E9Twi24952; Fri, 14 Sep 2001 10:29:59 +0100 (BST) (envelope-from brian@freebsd-services.com) Received: from hak.lan.Awfulhak.org (brian@localhost [127.0.0.1]) by hak.lan.Awfulhak.org (8.11.6/8.11.6) with ESMTP id f8E9Tpd26809; Fri, 14 Sep 2001 10:29:51 +0100 (BST) (envelope-from brian@freebsd-services.com) Message-Id: <200109140929.f8E9Tpd26809@hak.lan.Awfulhak.org> X-Mailer: exmh version 2.5 07/13/2001 with nmh-1.0.4 To: Josef Karthauser Cc: Garance A Drosihn , Brian Somers , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org, brian@freebsd-services.com Subject: Re: Proposed patch to log_accum.pl In-Reply-To: Message from Josef Karthauser of "Fri, 14 Sep 2001 04:01:46 BST." <20010914040146.A32158@tao.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Fri, 14 Sep 2001 10:29:51 +0100 From: Brian Somers Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG > On Thu, Sep 13, 2001 at 10:32:00PM -0400, Garance A Drosihn wrote: > >=20 > > For parsing purposes, I was thinking of something more like: > >=20 > > Revision Changes Path > > 1.108 +6 -5 src/sys/kern/kern_descrip.c > > 1.1 +123 0 src/sys/kern/new_file.c (new) > > 1.234 0 -669 src/sys/kern/dead_file.c (attic) > >=20 > > I'd want the same number of columns under "Changes" for those people > > who parse this by splitting on blanks. > > That's a fair point, and the reason I put two columns in in the patch. > > How about: > > Revision Changes Path > 1.108 +6 -5 src/sys/kern/kern_descrip.c > 1.1 +123 X src/sys/kern/new_file.c (new) > 1.234 X -669 src/sys/kern/dead_file.c (attic) > > or some other character to pad the column out, but to indicate that > there's no value there? Hmm, I think the X looks odd. If we have (new) and (attic) then we don't need the Xs. If we have the Xs (or even if we have nothing) we don't need the (new) or (attic). Personally I prefer my original suggestion on the basis that it has no duplicated information. Parsing is easy, but not as easy as having a pad character. When all's said and done, a script can parse it whatever the format, so I think you should just decide what you think is best Joe :*) > Joe -- Brian http://www.freebsd-services.com/ Don't _EVER_ lose your sense of humour ! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message