Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 21 Mar 2017 10:19:24 +0100
From:      Mathieu Arnold <mat@FreeBSD.org>
To:        Gleb Smirnoff <glebius@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-src-head@freebsd.org, Antoine Brodin <antoine@freebsd.org>, svn-src-all@freebsd.org, FreeBSD Ports <freebsd-ports@freebsd.org>
Subject:   Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt
Message-ID:  <81f57d51-8ccf-e0a7-ec9a-5ef816998e76@FreeBSD.org>
In-Reply-To: <20170321072714.GN23308@FreeBSD.org>
References:  <201703210639.v2L6dnRf055522@repo.freebsd.org> <20170321064154.GL23308@FreeBSD.org> <CAALwa8nMoaO64_YRFxGTXR42AJQyqaTq=jSLBB6sp6pfPcw8%2BA@mail.gmail.com> <20170321065433.GM23308@FreeBSD.org> <20170321072219.ij2waf2rygmvezoh@ivaldir.net> <20170321072714.GN23308@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--ctH08Red9og3IeD3F9I9jDBxnJW5TtNjq
Content-Type: multipart/mixed; boundary="3G6t57FRSj5oxA7wT2xXjEinbLQtHvp8S";
 protected-headers="v1"
From: Mathieu Arnold <mat@FreeBSD.org>
To: Gleb Smirnoff <glebius@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>
Cc: svn-src-head@freebsd.org, Antoine Brodin <antoine@freebsd.org>,
 svn-src-all@freebsd.org, FreeBSD Ports <freebsd-ports@freebsd.org>
Message-ID: <81f57d51-8ccf-e0a7-ec9a-5ef816998e76@FreeBSD.org>
Subject: Re: svn commit: r315662 - in head: contrib/bsnmp/snmp_mibII
 contrib/ipfilter/ipsend lib/libprocstat sys/netinet sys/sys usr.bin/netstat
 usr.bin/sockstat usr.bin/systat usr.sbin/tcpdrop usr.sbin/trpt
References: <201703210639.v2L6dnRf055522@repo.freebsd.org>
 <20170321064154.GL23308@FreeBSD.org>
 <CAALwa8nMoaO64_YRFxGTXR42AJQyqaTq=jSLBB6sp6pfPcw8+A@mail.gmail.com>
 <20170321065433.GM23308@FreeBSD.org>
 <20170321072219.ij2waf2rygmvezoh@ivaldir.net>
 <20170321072714.GN23308@FreeBSD.org>
In-Reply-To: <20170321072714.GN23308@FreeBSD.org>

--3G6t57FRSj5oxA7wT2xXjEinbLQtHvp8S
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Le 21/03/2017 =C3=A0 08:27, Gleb Smirnoff a =C3=A9crit :
> On Tue, Mar 21, 2017 at 08:22:19AM +0100, Baptiste Daroussin wrote:
> B> On Mon, Mar 20, 2017 at 11:54:33PM -0700, Gleb Smirnoff wrote:
> B> > On Tue, Mar 21, 2017 at 07:50:32AM +0100, Antoine Brodin wrote:
> B> > A> >   This change is known to break a ton of ports. More than 100=
 if
> B> > A> > counting depends. I'm sorry for that and I already started to=
 fix
> B> > A> > them.
> B> > A> >
> B> > A> > Please send all new breakages to me.
> B> > A>=20
> B> > A> Hi,
> B> > A>=20
> B> > A> Exp-runs should happen before breakage happens, not after.
> B> > A> If you already know that it breaks hundreds of ports, please re=
vert
> B> > A> and request an exp-run.
> B> >=20
> B> > The exp-run has already been made:
> B> >=20
> B> > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D210673
> B> >=20
> B> > Wasn't very helpful.
> B> >=20
> B>=20
> B> I disagree it was useful it showed you some ports that were breaking=
 given there
> B> was some high level one you were expected to provide patches to fix =
them.
>
> I'm working on them right now.

You should have worked on it *before* the patch breaking everything
landed, providing patches for the ports that were reported as broken,
and repeat until all the ports that were building before were building
again.

You should **not** have committed the patch to the src tree before all
those patches were created, and you should have committed all the
patches at once, preferably before committing the patch to the src tree.


--=20
Mathieu Arnold



--3G6t57FRSj5oxA7wT2xXjEinbLQtHvp8S--

--ctH08Red9og3IeD3F9I9jDBxnJW5TtNjq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQJ8BAEBCgBmBQJY0PAdXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w
ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz
QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IbrkP/A9iqvNzbJz2BlimQXIFJqXn
qqA1IejQOWf5hTqQGAbgwYMgqF7z2V3/7uVCx/8TOw1aBFqhkGnr8jHfhcjCrrDu
2HcUxkhAmj4BsmiuqY+xdcCsjp1sT6YsDd9bfxWM+hZVpPx/X9Rsn9v6ovI0C9f7
e6njzGWakw4M2QU9aVasFfEU6IdaD3OMvHhzuqmfNtPse0Wdn3HxN49VQYOb4MjJ
5QwXqorwVoP3BYfLqWtUwXp6H6p//pLOZN5aLXG5P5eIwXbSBss48I1wPolSauV/
87v7dAnfLZpKBsGW4wDW9jAzIR6ueQRzxcrlcayqab9zRuiIs60KylTOzzGacpwm
q+O9RitGhOGJCAK8sore2/bJ61xkzab3bf0eeMgwSixlYEqO4bwkAF0D4jvQQCH8
1oagASi6AlCUlFjcf9dgu3CMCrqt9OMzHWwlTVGi8HxOb0mMTM9SanGgV9Hl5EkT
2pibjNjW2/9Niby5BXiHNO2eVHYrSv0exFKrJJfno8VfDgwKLeEyN52BOzOKP22G
sQkhYrbpdIHWUo3s4H6ILR/uHsEetImCanvGp6qxRmgqW0f4C2cldjcrEH7rDzJg
sN4iRpNpMp5NYahUaC00viGKe++N3VMx8Ho1H0qLFuyTJpB3yaj8kl1YAnvmJ7j0
6xM5QkGq165PfJ61yMwn
=rNRe
-----END PGP SIGNATURE-----

--ctH08Red9og3IeD3F9I9jDBxnJW5TtNjq--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81f57d51-8ccf-e0a7-ec9a-5ef816998e76>