From owner-cvs-all@FreeBSD.ORG Wed Apr 11 13:44:55 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id AE09A16A401; Wed, 11 Apr 2007 13:44:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41]) by mx1.freebsd.org (Postfix) with ESMTP id 8AA1213C455; Wed, 11 Apr 2007 13:44:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l3BDitbx071470; Wed, 11 Apr 2007 13:44:55 GMT (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l3BDitGf071469; Wed, 11 Apr 2007 13:44:55 GMT (envelope-from jhb) Message-Id: <200704111344.l3BDitGf071469@repoman.freebsd.org> From: John Baldwin Date: Wed, 11 Apr 2007 13:44:55 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/sys mutex.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2007 13:44:55 -0000 jhb 2007-04-11 13:44:55 UTC FreeBSD src repository Modified files: sys/sys mutex.h Log: Group the loop to acquire/release Giant with the WITNESS_SAVE/RESTORE under a single conditional. The two operations are linked, but since the link is not very direct, Coverity can't see it. Humans might also miss the link as well. So, this isn't fixing any actual bugs, just improving readability. CID: 1787 (likely others as well) Found by: Coverity Prevent (tm) Revision Changes Path 1.95 +10 -8 src/sys/sys/mutex.h