From owner-freebsd-chat Wed Jan 27 23:41:07 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id XAA01876 for freebsd-chat-outgoing; Wed, 27 Jan 1999 23:41:07 -0800 (PST) (envelope-from owner-freebsd-chat@FreeBSD.ORG) Received: from allegro.lemis.com (allegro.lemis.com [192.109.197.134]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id XAA01869 for ; Wed, 27 Jan 1999 23:41:04 -0800 (PST) (envelope-from grog@freebie.lemis.com) Received: from freebie.lemis.com (freebie.lemis.com [192.109.197.137]) by allegro.lemis.com (8.9.1/8.9.0) with ESMTP id SAA23814; Thu, 28 Jan 1999 18:11:01 +1030 (CST) Received: (from grog@localhost) by freebie.lemis.com (8.9.2/8.9.0) id SAA08591; Thu, 28 Jan 1999 18:10:59 +1030 (CST) Date: Thu, 28 Jan 1999 18:10:59 +1030 From: Greg Lehey To: Nate Williams Cc: Archie Cobbs , Garrett Wollman , chat@FreeBSD.ORG Subject: -Wall (was: btokup() macro in sys/malloc.h) Message-ID: <19990128181059.C8473@freebie.lemis.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.1i In-Reply-To: <199901280540.WAA26288@mt.sri.com>; from Nate Williams on Wed, Jan 27, 1999 at 10:40:16PM -0700 WWW-Home-Page: http://www.lemis.com/~grog Organization: LEMIS, PO Box 460, Echunga SA 5153, Australia Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-41-739-7062 Sender: owner-freebsd-chat@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org [moved to -chat] On Wednesday, 27 January 1999 at 22:40:16 -0700, Nate Williams wrote: >> Anyway, if we're going to -Wall'ify the kernel (as we should) >> then we need to update sytle(9) to reflect that. >> >> In fact, style(9) should say: >> >> If at all possible, your code should compile without warnings >> when the gcc -Wall flag is given. > > I disagree. As has been shown many times in the past (and I suspect the > down-under constituent will show that at least a couple of the > 'warnings' fixes will be wrong and hide bogus code), making -Wall a goal > causes people to cover up bad code with bad casts and such. > > '-Wall' is *NOT* a good design goal. It works both ways. On the one hand, I hate having to put dummy initialization in for variables that never get used uninitialized, but in ways that the optimizer can't recognize. On the other hand, just today (or yesterday, depending on how you look at it), Matt Dillon changed some stuff in vinum to remove some warnings, and at the same time coincidentally fixed a latent bug. Greg -- See complete headers for address, home page and phone numbers finger grog@lemis.com for PGP public key To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message