From owner-freebsd-stable@FreeBSD.ORG Mon Jul 16 13:40:38 2007 Return-Path: X-Original-To: stable@freebsd.org Delivered-To: freebsd-stable@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0690C16A403 for ; Mon, 16 Jul 2007 13:40:38 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68]) by mx1.freebsd.org (Postfix) with ESMTP id E4F9213C494 for ; Mon, 16 Jul 2007 13:40:37 +0000 (UTC) (envelope-from rizzo@icir.org) Received: from xorpc.icir.org (localhost [127.0.0.1]) by xorpc.icir.org (8.12.11/8.13.6) with ESMTP id l6GDJKF5096356; Mon, 16 Jul 2007 06:19:20 -0700 (PDT) (envelope-from rizzo@xorpc.icir.org) Received: (from rizzo@localhost) by xorpc.icir.org (8.12.11/8.12.3/Submit) id l6GDJKJN096355; Mon, 16 Jul 2007 06:19:20 -0700 (PDT) (envelope-from rizzo) Date: Mon, 16 Jul 2007 06:19:20 -0700 From: Luigi Rizzo To: Matthieu Michaud Message-ID: <20070716061920.A96306@xorpc.icir.org> References: <1397BA88-CC55-4585-86CB-3BD08FBABEF5@epita.info> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <1397BA88-CC55-4585-86CB-3BD08FBABEF5@epita.info>; from matthieu@epita.info on Mon, Jul 16, 2007 at 01:10:46PM +0200 Cc: stable@freebsd.org Subject: Re: make struct timeval posix compliant ? X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2007 13:40:38 -0000 On Mon, Jul 16, 2007 at 01:10:46PM +0200, Matthieu Michaud wrote: > hello, > > on RELENG_6 sys/_timeval.h defines (struct timeval).tv_sec as long. > posix wants it to be a time_t. this seems to have been corrected a > long time ago in HEAD (see [1]). i took time to 'make universe' in a > RELENG_6 tree with the HEAD src/sys/sys/_timeval.h. i've found > similar breakage. here's a patch which correct it the same way. this > sounds like an idea with pros (conformance) and cons (abi change). > anyone interested in those changes ? the patch seems small, so i think it is a good thing to apply the change, as this should also simplify porting third party apps and reduce diffs with HEAD. cheers luigi