From owner-cvs-all Fri Jan 11 13:49:30 2002 Delivered-To: cvs-all@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 7295F37B400; Fri, 11 Jan 2002 13:49:19 -0800 (PST) Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id g0BLnED85763; Fri, 11 Jan 2002 16:49:14 -0500 (EST) (envelope-from robert@fledge.watson.org) Date: Fri, 11 Jan 2002 16:49:14 -0500 (EST) From: Robert Watson X-Sender: robert@fledge.watson.org To: Poul-Henning Kamp Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/ufs/ufs ufs_quota.c In-Reply-To: <200201101502.g0AF2wD46831@freefall.freebsd.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=ISO-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG A nice catch indeed. There's a number of things about unmounting that may be questionable; I'm aware of a couple of bugs in remounting relating to the EA code, and wouldn't be surprised if similar bugs apply in the quota code and elsewhere. Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On Thu, 10 Jan 2002, Poul-Henning Kamp wrote: > phk 2002/01/10 07:02:58 PST >=20 > Modified files: > sys/ufs/ufs ufs_quota.c=20 > Log: > Do not pull quota entries of the cache-list if they have already > been removed from the cache-list as part of a previous unmount. > =20 > This would result in panics (page fault in dqflush()) during subsequent > umounts provided that enough distinct UID's to actually make the > hash do something are active. > =20 > This can probably explain a number of weird quota related behaviours. > =20 > PR: 32331 maybe more. > Reproduced by: S=F8ren Schr=F8rder > =20 > Revision Changes Path > 1.50 +2 -1 src/sys/ufs/ufs/ufs_quota.c >=20 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message