Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 18 Apr 2002 17:09:20 -0700
From:      "David O'Brien" <obrien@FreeBSD.org>
To:        Dag-Erling Smorgrav <des@ofug.org>
Cc:        cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/lib/libypclnt Makefile
Message-ID:  <20020418170920.B99972@dragon.nuxi.com>
In-Reply-To: <xzphem88v9w.fsf@flood.ping.uio.no>; from des@ofug.org on Fri, Apr 19, 2002 at 01:03:07AM %2B0200
References:  <20020418192213.GW24261@daemon.ninth-circle.org> <200204181620.g3IGKIu51885@freefall.freebsd.org> <200204182117.g3ILHIx08776@harmony.village.org> <xzphem88v9w.fsf@flood.ping.uio.no>

next in thread | previous in thread | raw e-mail | index | archive | help
I tried hard to not respond to this... but you want to make way too many
unsubstantiated claims in public...


On Fri, Apr 19, 2002 at 01:03:07AM +0200, Dag-Erling Smorgrav wrote:
> To add insult to injury, he did send out a "heads-up" about
> the commit, but half an hour *after* the fact.

Revisionist history.  I asked you 3 days *before* the commit.
http://people.freebsd.org/~obrien/libypclnt-Makefile.mbox

> I replied, thinking he
> expected feedback, and offered a compromise solution.  When I
> discovered that he had already made the commit, however, I took it as
> a clear indication that he was not interested in anything I have to
> say about the matter, but only in "being right" or "winning".

Feh.  You stated something as "fact", I replied it was opinion (you
disagreed it was "debatable" -- all can see the archives):

    From: Dag-Erling Smorgrav <des@ofug.org>
    Message-ID: <xzp4ri9ottx.fsf@flood.ping.uio.no>
    "David O'Brien" <obrien@freebsd.org> writes:
    > On Thu, Apr 18, 2002 at 06:07:59PM +0200, Dag-Erling Smorgrav wrote:
    > > Single-line lists makes adding files much more
    > > difficult,
    > That is a matter of opinion.
    No, it is not.  It is a fact.


At that point I could tell pleasing you was going to be difficult, and
*invited you* to please make the changes you wanted WRT your line file
per line as that would be easier on both of us:

    And I will back out your back out.  Changing what I committed to
    something simular to other FreeBSD Makefiles is what you should do.
    I guess there are instances of what you have above, so if that is
    really what you want to do, I guess you should do that.  But I will
    not do it, as you did not speak up before and I don't want to have 5
    rounds of review to find something you won't "back out".


> My intent with backing out his commit was to bring us back to square one
> so we could discuss this properly before deciding on a solution.

Your intent was to break the committer guidelines and commonly accepted
"best practices" of putting on the breaks once it was clear we were in
the middle of controversy.


> David claims that listing multiple files on a single line does not

READ my words -- I DO NOT CARE.

> the style I currently use (which is based on the style used in the
> ports tree) after one too many merge conflicts caused by listing

The Ports tree does NOT use:
    SYM<tab>=
    SYM<tab>+=<tab><tab>VAL

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020418170920.B99972>