Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Apr 2010 15:50:26 -0700
From:      Sam Leffler <sam@errno.com>
To:        Jack F Vogel <jfv@FreeBSD.org>
Cc:        svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: svn commit: r206429 - head/sys/dev/e1000
Message-ID:  <4BC25232.9070601@errno.com>
In-Reply-To: <201004091842.o39IgFbb031014@svn.freebsd.org>
References:  <201004091842.o39IgFbb031014@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Jack F Vogel wrote:
> Author: jfv
> Date: Fri Apr  9 18:42:15 2010
> New Revision: 206429
> URL: http://svn.freebsd.org/changeset/base/206429
> 
> Log:
>   Incorporate suggested improvements from yongari.
>   
>   Also, from feedback, make the multiqueue code an
>   option (EM_MULTIQUEUE) that is off by default.
>   Problems have been seen with UDP when its on.

It is usually a good idea to say what the "suggested improvements" are 
as it's unlikely anyone looking at the commit will have the needed 
context (I certainly did not).

It also seems that you roll-up unrelated changes in one commit; this is 
not advisable.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4BC25232.9070601>