Date: Fri, 20 Jan 2017 07:29:52 +0100 From: Antoine Brodin <antoine@freebsd.org> To: Xin LI <delphij@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r312404 - head/usr.bin/sed Message-ID: <CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ@mail.gmail.com> In-Reply-To: <201701190801.v0J81ZG9008267@repo.freebsd.org> References: <201701190801.v0J81ZG9008267@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jan 19, 2017 at 9:01 AM, Xin LI <delphij@freebsd.org> wrote: > Author: delphij > Date: Thu Jan 19 08:01:35 2017 > New Revision: 312404 > URL: https://svnweb.freebsd.org/changeset/base/312404 > > Log: > Use S_ISREG instead of manual & (also it's better to compare the > result from & and the pattern instead of just assuming it's one bit > value). > > Pointed out by Tianjie Mao <tjmao tjmao com>. > > MFC after: 2 weeks > Differential Revision: https://reviews.freebsd.org/D4827 Hi, sed -i no longer works on symlinks which breaks lots of ports. Please revert and request an exp-run. Cheers, Antoine
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAALwa8neni57SPZAo4jW8wKu-Up0-M=weR31WtndzXdW2_jKmQ>