Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 5 Oct 2019 14:56:28 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r353124 - stable/11/sys/kern
Message-ID:  <201910051456.x95EuSZr073019@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Sat Oct  5 14:56:27 2019
New Revision: 353124
URL: https://svnweb.freebsd.org/changeset/base/353124

Log:
  MFC r353010:
  Disallow fcntl(F_READAHEAD) when the vnode is not a regular file.

Modified:
  stable/11/sys/kern/kern_descrip.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/kern/kern_descrip.c
==============================================================================
--- stable/11/sys/kern/kern_descrip.c	Sat Oct  5 13:28:01 2019	(r353123)
+++ stable/11/sys/kern/kern_descrip.c	Sat Oct  5 14:56:27 2019	(r353124)
@@ -765,6 +765,12 @@ kern_fcntl(struct thread *td, int fd, int cmd, intptr_
 			break;
 		}
 		vp = fp->f_vnode;
+		if (vp->v_type != VREG) {
+			fdrop(fp, td);
+			error = ENOTTY;
+			break;
+		}
+
 		/*
 		 * Exclusive lock synchronizes against f_seqcount reads and
 		 * writes in sequential_heuristic().



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910051456.x95EuSZr073019>