From owner-svn-src-head@freebsd.org Fri Aug 19 05:33:40 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AE706BBE793 for ; Fri, 19 Aug 2016 05:33:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-pf0-x230.google.com (mail-pf0-x230.google.com [IPv6:2607:f8b0:400e:c00::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 649491A07 for ; Fri, 19 Aug 2016 05:33:40 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-pf0-x230.google.com with SMTP id p64so5861202pfb.1 for ; Thu, 18 Aug 2016 22:33:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=Jx1mP6I5p+T7MOiWki8kiNSqTNOblyPuppv3sU8Nlr4=; b=w/G6Qod0HiO25lpPbt5HIOYSgXaVXh8W6b6+1HawdlkKRW9VI3iQQ5utZsr7v/0bDu vEgtVSbjcZftyew660VfchIw2lKueNXMOwb+EJ7nGGC/BkkW7EDj69WArpRM1pP2dBK/ 9Mk3G9nqJran+3xGy1z6vyZ5NZaUvvmyJCye1eugUf2CekjLQC/4YnItEIn3L+Tj8+eQ emArG/4zvle9P/JtMM8yucNs0SD2f0G32mz1P2Ct09jf5dyI4pkLk8+3TAM8R5NCIoiS 5IFfxkia98BLTnCPEqzLY9QSy7Gw9UGMdo97ZC84h0gTL3goiR8I2aRKLglrRZNAWc1P x7Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=Jx1mP6I5p+T7MOiWki8kiNSqTNOblyPuppv3sU8Nlr4=; b=F4/Jg7FLm7DTqLGz+rShVkl+5hNSoQ94zJO/j5/KRFQh3YLeFB4LWz0P77TCyQwZ0S 4VKXIwrOkzlO4N6Jk7OV6hX251wrJzDqtA7BOaA5VGsMujveGfNdz5McODPXAuiAwZ/R QIdlpXRwaY3OkCtP3X9pBCSU1/l9sG9WeWrlknXHRZTBvz4PPNpMtUmXVd7Z/m7XX9s6 LcERW8tBVzn4+9KdycBG0/5DdjGFtFSzGeMhKeUS29/3UYz7DgD3FZUTNa8tePR6zZRs Cj3H2kY/7H4rCahh/TODG+occlUKtgsfPS4dgAqggn5ohLiES2e83/Bb9RJ755Q6LEGe ibVg== X-Gm-Message-State: AEkoouv8+1jccoJuTCk/LMRz3Q+dLhoPzOBdWkBRQWYJlVrlMn6eU6xNO8Sth+BQO/voNw== X-Received: by 10.98.210.69 with SMTP id c66mr10909746pfg.71.1471584819461; Thu, 18 Aug 2016 22:33:39 -0700 (PDT) Received: from [100.127.66.142] ([69.53.245.200]) by smtp.gmail.com with ESMTPSA id n80sm2805889pfi.19.2016.08.18.22.33.37 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 18 Aug 2016 22:33:38 -0700 (PDT) Subject: Re: svn commit: r304142 - head/usr.sbin/bsdinstall/partedit Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_57E9FE32-7095-4F78-A44E-0613250B6CE9"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: Warner Losh In-Reply-To: <081362ef-ff4a-61d5-46e4-9a4cf8b699ee@freebsd.org> Date: Thu, 18 Aug 2016 23:33:36 -0600 Cc: Warner Losh , Allan Jude , =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-Id: <880977BE-F00F-4188-A978-F292AB452C79@bsdimp.com> References: <201608150930.u7F9UL1V069576@repo.freebsd.org> <861t1n6749.fsf@desk.des.no> <581c856c-826b-529e-c9c6-a397fb679708@freebsd.org> <86wpjf4eun.fsf@desk.des.no> <8cb3fa1a-50cb-e238-d006-b98a628d446d@freebsd.org> <86k2ff4cxs.fsf@desk.des.no> <86fuq24d8s.fsf@desk.des.no> <2f9fb04c-7ec4-be40-8fcb-0cf74bb56859@freebsd.org> <081362ef-ff4a-61d5-46e4-9a4cf8b699ee@freebsd.org> To: Nathan Whitehorn X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 05:33:40 -0000 --Apple-Mail=_57E9FE32-7095-4F78-A44E-0613250B6CE9 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Aug 18, 2016, at 11:21 PM, Nathan Whitehorn = wrote: >=20 >=20 >=20 > On 08/18/16 21:15, Warner Losh wrote: >> On Thu, Aug 18, 2016 at 6:56 AM, Allan Jude = wrote: >>> On 08/18/16 05:50 AM, Dag-Erling Sm=C3=B8rgrav wrote: >>>> Nathan Whitehorn writes: >>>>> OK. In which configurations? My Dell servers, for instance, don't = do >>>>> this. How are they set up? What drivers are being used? Is this >>>>> something that affects passthrough disks, RAIDs, disk images? >>>> Most LSI MegaRAID controllers don't have real passthrough, only = JBOD. >>>> You can query the drive with "camcontrol identify passX", but the >>>> controller does not report a stripe size for the volume (mfidY). >>>>=20 >>>>> The point is that *if the reported stripe size is wrong*, more = things >>>>> than partition alignment in the installer will suffer for it. >>>> It's not wrong, it's non-existent, and I'm getting really tired of >>>> repeating myself. >>>>=20 >>>>> Fixing the installer with a bandaid in the run-up to a release is >>>>> fine, but *we need to fix the underlying problem*. >>>> We can't, because hardware sucks, and I'm getting really tired of >>>> repeating myself. >>>>=20 >>>> DES >>>>=20 >>> Which makes more sense: >>>=20 >>> A) If stripesize =3D=3D 0, use some sane value like 4096 >> I don't like this. >>=20 >>> B) Some other combination that uses the reported stripe size, unless = it >>> is 0, in which case it uses 4096 (or some other value controlled by = a >>> different new sysctl) >> Don't like this so much. >>=20 >>> C) create kern.geom.min_stripe_size with a default of 512, but users = can >>> set 4096 if they use only 4k devices. (doesn't really solve the = problem >>> for the installer) >> Default it to 4k, and allow users to set it to 512. If the drive >> reports < this value >> report this value instead. You'll need to make this a tunable. Then = the upper >> layers wouldn't care. There's a small chance that some SD cards might = be >> reporting values that are too large. But I think it is confined to SD = cards and >> if I see too many more I'll do something specific in the SD driver. >>=20 >> Warner >>=20 >>=20 >=20 > That sounds good to me and I think can clean up a lot of code and = potential foot-shooting. Who is planning to make the patch? I'm happy to = do anything that would be helpful. The patch is super-easy, but I need to get the concept validated and = make sure that it does not have unintended side effects. Warner --Apple-Mail=_57E9FE32-7095-4F78-A44E-0613250B6CE9 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJXtpowAAoJEGwc0Sh9sBEAim0QAK13yHj3lbOzgRjx2Nh+FVAY BCLWRCEZC06sZ2cSxYi0LuTqgArYOKOXcgOacDDM2EbQz55Gj8SPWUenTIk0OVt/ 8BKnIytKqrv6mganZ7Rgyq0JLYmdcohAmqTDivrkx5Z983nwoMbYkAafrPKpjpL/ 3awi6+yUMw1s82jmQ3XbzDT8kfSI2aExgnJa9YRJ8R/oRZpVIWKJTY27lQHzDef/ OsTOtC/OjRQ7V7WHacyL2Pfm0XOFTM0JjPp0GK9BZy8LrtEle9ybRg4fnCo1wdwp dx2evQX6jmxG1mzHiMElpm6bN4A4PpWzjrSOQ4PO+1Ep4yd/OieDH5JmPoiGYywg qSssFUAyunf+4qW97pjwa7o+epR4iub7ITBaPyQgfFQvzn0BOnhNRCvVrTmxwcKN 6gDuwgFoaEIVP6bWlYENKMZsUtnqYzYyazEDT2pptE4wpjerw7i8LGC53f0Pz21+ /N5+hSnqZ3EvuQKX4FUKoiAl0x/1OASYYdjOCsq2sv3HZ04u7Mrbusjxk8eWGrLb 2od39bX9Ew4RhCFMxUNL4z0hci1LRTHWFnjhajXyDmX/rns8BuhFCHvtoohG4N6j C8uT14L6Oczlh1hc0GPfxyFeUCjSxX30OAiLvrHAnatGML+XQ1x/WSjWg+kmVmXd 4y4qoA5bnwxHL1GILyir =smyh -----END PGP SIGNATURE----- --Apple-Mail=_57E9FE32-7095-4F78-A44E-0613250B6CE9--