From owner-cvs-all@FreeBSD.ORG Wed Dec 31 08:56:34 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3431C16A4CE; Wed, 31 Dec 2003 08:56:34 -0800 (PST) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8EB743D48; Wed, 31 Dec 2003 08:56:32 -0800 (PST) (envelope-from jhb@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id hBVGuW0B040722; Wed, 31 Dec 2003 08:56:32 -0800 (PST) (envelope-from jhb@repoman.freebsd.org) Received: (from jhb@localhost) by repoman.freebsd.org (8.12.10/8.12.10/Submit) id hBVGuWxN040721; Wed, 31 Dec 2003 08:56:32 -0800 (PST) (envelope-from jhb) Message-Id: <200312311656.hBVGuWxN040721@repoman.freebsd.org> From: John Baldwin Date: Wed, 31 Dec 2003 08:56:32 -0800 (PST) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/i386/pci pci_cfgreg.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Dec 2003 16:56:34 -0000 jhb 2003/12/31 08:56:32 PST FreeBSD src repository Modified files: sys/i386/pci pci_cfgreg.c Log: Replace an outb() during the test for configuration mechanism #1 with a DELAY(1) instead. After wading through old commit logs, I found that the outb() was added not as part of the test but as an intentional delay. In fact, according to Shanley's PCI book, the configuration 1 data and address ports should only be accessed using aligned 32-bit accesses (i.e. inl() and outl()). Thus, using outb() to just the last byte of the port violates the PCI spec it would seem. On at least one box doing so broke the probe for PCI, whereas changing it to a DELAY(1) fixed the probe. Reported by: Sean Welch MFC after: 1 week Revision Changes Path 1.108 +1 -1 src/sys/i386/pci/pci_cfgreg.c