Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 24 Sep 2015 14:23:55 -0700
From:      Warner Losh <imp@bsdimp.com>
To:        Bryan Drewery <bdrewery@freebsd.org>
Cc:        Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>,  "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>
Subject:   Re: svn commit: r287263 - head/sys/conf
Message-ID:  <CANCZdfq%2B2ES=swX3h_zHFUZTNgyuPcBfK59rtd5E1OVvWA8NPA@mail.gmail.com>
In-Reply-To: <5604556B.2070906@FreeBSD.org>
References:  <201508281629.t7SGTdnb063079@repo.freebsd.org> <5604556B.2070906@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
I don't think so. I'd like to fix this more properly. However, without this
hack, anything in the tree that ends in _if.c or _if.h will get deleted,
which is bad as you might imagine. There's two or three drivers that
are built as modules that fit this pattern.

I really don't want to back out r258068. Having a list of all the places
to look for _if.m files is really annoying...

Warner

On Thu, Sep 24, 2015 at 12:56 PM, Bryan Drewery <bdrewery@freebsd.org>
wrote:

> On 8/28/2015 9:29 AM, Warner Losh wrote:
> > Author: imp
> > Date: Fri Aug 28 16:29:38 2015
> > New Revision: 287263
> > URL: https://svnweb.freebsd.org/changeset/base/287263
> >
> > Log:
> >   Comment out cleaning files, since it cleans too much.
> >
> > Modified:
> >   head/sys/conf/kmod.mk
> >
> > Modified: head/sys/conf/kmod.mk
> >
> ==============================================================================
> > --- head/sys/conf/kmod.mk     Fri Aug 28 16:23:03 2015        (r287262)
> > +++ head/sys/conf/kmod.mk     Fri Aug 28 16:29:38 2015        (r287263)
> > @@ -361,7 +361,8 @@ _MPATH=${__MPATH:H:O:u}
> >  .endif
> >  .PATH.m: ${_MPATH}
> >  .for _i in ${SRCS:M*_if.[ch]}
> > -CLEANFILES+= ${_i}
> > +#removes too much, comment out until it's more constrained.
> > +#CLEANFILES+=        ${_i}
> >  .endfor # _i
> >  .m.c:        ${SYSDIR}/tools/makeobjops.awk
> >       ${AWK} -f ${SYSDIR}/tools/makeobjops.awk ${.IMPSRC} -c
> >
>
> Rather than this should r285068 be reverted to restore CLEANFILES
> handling of these generated files?
>
> --
> Regards,
> Bryan Drewery
>
>



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfq%2B2ES=swX3h_zHFUZTNgyuPcBfK59rtd5E1OVvWA8NPA>