From owner-svn-src-all@freebsd.org Thu Sep 24 21:23:57 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1933CA085DD for ; Thu, 24 Sep 2015 21:23:57 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qg0-f52.google.com (mail-qg0-f52.google.com [209.85.192.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id DDF071A53 for ; Thu, 24 Sep 2015 21:23:56 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qgt47 with SMTP id 47so55531430qgt.2 for ; Thu, 24 Sep 2015 14:23:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=Z18WvPe9+fhwy9kwaIKq9zGNXCTY2JPcy+B2rJlzNVI=; b=Cq6fRmxeCe/suYgozilEzdE0vqeyfhlhozmQ7J07wIPWapWz2AKpmXXNsCy9xbU7iG lUqzGcq0u4dsIQoWGXq82FmdZ26RNQvDHkE+vqXwSX0nM4WPfAo+HDamS2bbEtJPldn5 7DYMCwi1+CqE7vG8tbquFf6AVKe91JmEbzzQ1znOeXAuJ7a2RXfSFuubkjkLml/OL5Yb rq3iqiZ3eDyL8G++Ta7BgiS69xdRoyApkWWmyyVoVenELzqdLStkGEGIVQjZ4omPAr4L Y8vE0mUwphURv1dzU5YFqznymgABry5O/iQIPzPoIFOdUMBAit65LbAfTW4tUEphCeTV 9xhw== X-Gm-Message-State: ALoCoQnyEv/8tt4eg2EGWh2Xjg+/0prkXRT2HROZom5DxCZKQ7B+B8kWvcYKQ6bB0vlZSvKYO8Xo MIME-Version: 1.0 X-Received: by 10.140.129.22 with SMTP id 22mr2480529qhb.74.1443129835793; Thu, 24 Sep 2015 14:23:55 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.140.80.167 with HTTP; Thu, 24 Sep 2015 14:23:55 -0700 (PDT) X-Originating-IP: [69.53.245.18] In-Reply-To: <5604556B.2070906@FreeBSD.org> References: <201508281629.t7SGTdnb063079@repo.freebsd.org> <5604556B.2070906@FreeBSD.org> Date: Thu, 24 Sep 2015 14:23:55 -0700 X-Google-Sender-Auth: TFLU4BHJIBYUuo_slMeushxgp_4 Message-ID: Subject: Re: svn commit: r287263 - head/sys/conf From: Warner Losh To: Bryan Drewery Cc: Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2015 21:23:57 -0000 I don't think so. I'd like to fix this more properly. However, without this hack, anything in the tree that ends in _if.c or _if.h will get deleted, which is bad as you might imagine. There's two or three drivers that are built as modules that fit this pattern. I really don't want to back out r258068. Having a list of all the places to look for _if.m files is really annoying... Warner On Thu, Sep 24, 2015 at 12:56 PM, Bryan Drewery wrote: > On 8/28/2015 9:29 AM, Warner Losh wrote: > > Author: imp > > Date: Fri Aug 28 16:29:38 2015 > > New Revision: 287263 > > URL: https://svnweb.freebsd.org/changeset/base/287263 > > > > Log: > > Comment out cleaning files, since it cleans too much. > > > > Modified: > > head/sys/conf/kmod.mk > > > > Modified: head/sys/conf/kmod.mk > > > ============================================================================== > > --- head/sys/conf/kmod.mk Fri Aug 28 16:23:03 2015 (r287262) > > +++ head/sys/conf/kmod.mk Fri Aug 28 16:29:38 2015 (r287263) > > @@ -361,7 +361,8 @@ _MPATH=${__MPATH:H:O:u} > > .endif > > .PATH.m: ${_MPATH} > > .for _i in ${SRCS:M*_if.[ch]} > > -CLEANFILES+= ${_i} > > +#removes too much, comment out until it's more constrained. > > +#CLEANFILES+= ${_i} > > .endfor # _i > > .m.c: ${SYSDIR}/tools/makeobjops.awk > > ${AWK} -f ${SYSDIR}/tools/makeobjops.awk ${.IMPSRC} -c > > > > Rather than this should r285068 be reverted to restore CLEANFILES > handling of these generated files? > > -- > Regards, > Bryan Drewery > >