From owner-cvs-all Sat Jun 23 14:37:45 2001 Delivered-To: cvs-all@freebsd.org Received: from ringworld.nanolink.com (diskworld.nanolink.com [195.24.48.189]) by hub.freebsd.org (Postfix) with SMTP id 07A0F37B406 for ; Sat, 23 Jun 2001 14:37:40 -0700 (PDT) (envelope-from roam@orbitel.bg) Received: (qmail 8128 invoked by uid 1000); 23 Jun 2001 21:35:59 -0000 Date: Sun, 24 Jun 2001 00:35:59 +0300 From: Peter Pentchev To: Matt Dillon Cc: Mikhail Teterin , jlemon@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: Inline optimized bzero (was Re: cvs commit: src/sys/netinet tcp_subr.c) Message-ID: <20010624003559.D564@ringworld.oblivion.bg> Mail-Followup-To: Matt Dillon , Mikhail Teterin , jlemon@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200106231912.f5NJCUE01011@aldan.algebra.com> <200106232102.f5NL2fY73920@earth.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200106232102.f5NL2fY73920@earth.backplane.com>; from dillon@earth.backplane.com on Sat, Jun 23, 2001 at 02:02:41PM -0700 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, Just a minor remark: this should either go in machine-dependent code, and really work on a size of the MD int type, or it should be called bzero32() or something, and work with int32_t. Other than that, yes, this looks like it would be a Good Thing(tm). G'luck, Peter -- Nostalgia ain't what it used to be. On Sat, Jun 23, 2001 at 02:02:41PM -0700, Matt Dillon wrote: > I would propose adding a new kernel bzero() function, called bzerol(), > which is an inline integer-aligned implementation. > This implementation should be called for integer-aligned buffers with > known (constant) sizes, and generates about the same number of assembly > instructions as calling bzero() eats. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message