From owner-svn-ports-all@FreeBSD.ORG Wed Sep 5 20:36:03 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 574E3106566C; Wed, 5 Sep 2012 20:36:03 +0000 (UTC) (envelope-from flo@smeets.im) Received: from mail.solomo.de (mail.solomo.de [85.214.62.193]) by mx1.freebsd.org (Postfix) with ESMTP id 085D38FC0C; Wed, 5 Sep 2012 20:36:02 +0000 (UTC) Received: from mail.solomo.de (localhost [127.0.0.1]) by mail.solomo.de (Postfix) with ESMTP id 0442DC382C; Wed, 5 Sep 2012 22:35:55 +0200 (CEST) X-Virus-Scanned: amavisd-new at solomo.de Received: from mail.solomo.de ([127.0.0.1]) by mail.solomo.de (mail.solomo.de [127.0.0.1]) (amavisd-new, port 10024) with LMTP id YWrvG79KEfDx; Wed, 5 Sep 2012 22:35:54 +0200 (CEST) Received: from nibbler-osx-wlan.fritz.box (unknown [IPv6:2001:4dd0:ff00:8bb6:b81f:4cde:8eec:29d9]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.solomo.de (Postfix) with ESMTPSA id 856A7C381A; Wed, 5 Sep 2012 22:35:53 +0200 (CEST) Message-ID: <5047B7A6.8040601@smeets.im> Date: Wed, 05 Sep 2012 22:35:50 +0200 From: Florian Smeets User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:16.0) Gecko/20120828 Thunderbird/16.0 MIME-Version: 1.0 To: Doug Barton References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <5045E904.5080608@smeets.im> <50462DEC.3040202@FreeBSD.org> In-Reply-To: <50462DEC.3040202@FreeBSD.org> X-Enigmail-Version: 1.5a1pre Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9059A5EA1C9C8721FF219EE5" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303626 - head/www/xpi-firebug X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Sep 2012 20:36:03 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9059A5EA1C9C8721FF219EE5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04.09.12 18:35, Doug Barton wrote: > On 9/4/2012 4:41 AM, Florian Smeets wrote: >=20 >> I still see this as a style nit. Can you be a bit more specific where >> portmaster fails with distinfo (or other files) not having the last >> newline? >=20 > I already explained it twice. :) >=20 > Take a file with no newline at the end. Do this: >=20 > while read line ; do > echo $line > done < badfile >=20 > The last line will not be "seen" by the shell because of the missing > newline. Yes, that is pretty clear. >=20 > Portmaster, and other tools, use this method extensively to read those > files, and this issue causes those tools to break while processing thos= e > files. >=20 You keep repeating this, without proof. This is what I do not see, and you so conveniently stripped that part out of your reply. portmaster does not break for me when there is a missing newline at the end of distinfo. It updates the port happily. This is what i meant with being more specific, how can the failure be reproduced? It seems most of this will be moot soon anyway, so maybe we should just let this case rest. However someone should perhaps fix all the files that have been added without newline at the end of the file. Florian --------------enig9059A5EA1C9C8721FF219EE5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlBHt6cACgkQapo8P8lCvwnS2gCgkHifiNdsAbesEBsJYGJa2GpN zh0AniBSz0UIcRAmuETeuChP0o7YTlsq =Px6/ -----END PGP SIGNATURE----- --------------enig9059A5EA1C9C8721FF219EE5--