Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 11 Apr 2004 01:37:15 +0700
From:      Alexey Dokuchaev <danfe@nsu.ru>
To:        Pierre Beyssac <pb@freebsd.org>
Cc:        ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/multimedia/kino Makefile distinfo pkg-descr pkg-plist ports/multimedia/kino/files patch-aa patch-ab patch-ac patch-ad patch-ae patch-af patch-ag patch-ah patch-ai patch-aj patch-ak patch-al patch-am patch-an patch-ao patch-ap patch-aq ...
Message-ID:  <20040410183715.GA79806@regency.nsu.ru>
In-Reply-To: <20040410181318.GB22179@fasterix.frmug.org>
References:  <200404101649.i3AGnKSq039638@repoman.freebsd.org> <20040410180132.GA65689@regency.nsu.ru> <20040410181318.GB22179@fasterix.frmug.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Apr 10, 2004 at 08:13:18PM +0200, Pierre Beyssac wrote:
> On Sun, Apr 11, 2004 at 01:01:32AM +0700, Alexey Dokuchaev wrote:
> > >   Kino 0.7.0.
> > >   Kino is an IEEE 1394 DV non-linear video editor.
> > >   Note: IEEE 1394 and V4L are disabled in this port.
> > Could you explain why (shortly)?
> 
> The IEEE 1394 code is totally Linux-specific and requires very
> significant work to port to FreeBSD (which already has fwcontrol(8)
> anyway). The V4L (video4linux) capture code is even more Linux-specific.
> But kino is still very useful as a DV editing tool so the port is
> worth it.

OK, thanks.

> 
> > AFAIK ``patch-xy'' is an old, deprecated naming scheme, superseded by
> > ``patch-path::to::file::to:patch.ext'' one.  Considering large number of
> > patch files for this port, it would be probably hard to "navigate"
> > through all these patches.
> 
> Since most of the patches are crude "#if 0" to disable IEEE 1394
> and V4L code, so I figured it doesn't matter much; split -p ^diff
> came in very handy. If the names are a real problem I can change
> that.

I don't really think renaming is worthwhile; however, it's more likely
that pathes would hit official distribution if they were not just "#if
0"s but careful wrappers (Linux/FreeBSD-aware, at least).

> 
> > Also, did submitter (or you) feed patches back to Kino's authors?
> 
> Of course, I'm going to. Actually there are just a few real bug-fix
> patches (one for X11 SHM support, two others for uninitialized
> pointers...), and I need to check what's in 0.7.1 which was released...
> yesterday.

Cool.  Thank you for bringing more of high-quality multimedia software
like this one into FreeBSD.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040410183715.GA79806>