From owner-svn-src-head@freebsd.org Thu Jul 19 20:19:03 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C284E1048BA2 for ; Thu, 19 Jul 2018 20:19:03 +0000 (UTC) (envelope-from ian@freebsd.org) Received: from pmta2.delivery6.ore.mailhop.org (pmta2.delivery6.ore.mailhop.org [54.200.129.228]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 45F43793CB for ; Thu, 19 Jul 2018 20:19:03 +0000 (UTC) (envelope-from ian@freebsd.org) X-MHO-RoutePath: aGlwcGll X-MHO-User: f5fe3a45-8b90-11e8-b829-b3adae557cda X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information X-Originating-IP: 67.177.211.60 X-Mail-Handler: DuoCircle Outbound SMTP Received: from ilsoft.org (unknown [67.177.211.60]) by outbound2.ore.mailhop.org (Halon) with ESMTPSA id f5fe3a45-8b90-11e8-b829-b3adae557cda; Thu, 19 Jul 2018 20:18:56 +0000 (UTC) Received: from rev (rev [172.22.42.240]) by ilsoft.org (8.15.2/8.15.2) with ESMTP id w6JKItk6003780; Thu, 19 Jul 2018 14:18:55 -0600 (MDT) (envelope-from ian@freebsd.org) Message-ID: <1532031535.1344.11.camel@freebsd.org> Subject: Re: svn commit: r336503 - in head/sys: netinet netinet6 From: Ian Lepore To: Devin Teske Cc: Alexey Dokuchaev , Michael Tuexen , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Date: Thu, 19 Jul 2018 14:18:55 -0600 In-Reply-To: <06745A7A-2E1C-4E48-ADCE-F42447B28A2C@FreeBSD.org> References: <201807191933.w6JJXhof018383@repo.freebsd.org> <20180719195302.GA26853@FreeBSD.org> <1532030389.1344.9.camel@freebsd.org> <06745A7A-2E1C-4E48-ADCE-F42447B28A2C@FreeBSD.org> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 20:19:03 -0000 On Thu, 2018-07-19 at 13:12 -0700, Devin Teske wrote: > > > > On Jul 19, 2018, at 12:59 PM, Ian Lepore wrote: > > > > On Thu, 2018-07-19 at 19:53 +0000, Alexey Dokuchaev wrote: > > > > > > > > > > > +++ head/sys/netinet/sctp_asconf.c    Thu Jul 19 19:33:42 2018        (r336503) > > > >   static struct mbuf * > > > > -sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t *error_tlv, > > > > +sctp_asconf_error_response(uint32_t id, uint16_t cause, uint8_t * error_tlv, > > > This looks strange now.  In C, asterisk is usually placed by the variable. > > "usually" may be true of freebsd, but most places I've worked consider > > the * (and & in c++) to be more associated with the type being declared > > than with the variable name, thus they get snugged up against the type > > info, not the var name. Putting the * or & with the var name leads to > > particularly bad constructs such as  > > > >  int a, *b; > > > > which, for maximal clarity, should be: > > > >   int  a; > >   int* b; > > > Are we free to prefer the former in C if that's how we've been coding in C for 20+ years? Only if I'm free to consider that kind of sarcasm to be a completely inappropriate response to what I said. -- Ian