From owner-cvs-all  Sat Jul  1 16:28:50 2000
Delivered-To: cvs-all@freebsd.org
Received: from bubba.whistle.com (bubba.whistle.com [207.76.205.7])
	by hub.freebsd.org (Postfix) with ESMTP
	id D7F5137B788; Sat,  1 Jul 2000 16:28:40 -0700 (PDT)
	(envelope-from archie@whistle.com)
Received: (from archie@localhost)
	by bubba.whistle.com (8.9.3/8.9.2) id QAA06644;
	Sat, 1 Jul 2000 16:28:36 -0700 (PDT)
From: Archie Cobbs <archie@whistle.com>
Message-Id: <200007012328.QAA06644@bubba.whistle.com>
Subject: Re: cvs commit: src/sys/net if.c if_ethersubr.c if_var.h
In-Reply-To: <200007012021.OAA53771@harmony.village.org> from Warner Losh at "Jul 1, 2000 02:21:43 pm"
To: imp@village.org (Warner Losh)
Date: Sat, 1 Jul 2000 16:28:36 -0700 (PDT)
Cc: archie@whistle.com (Archie Cobbs),
	ache@FreeBSD.org (Andrey A. Chernov),
	archie@FreeBSD.org (Archie Cobbs), cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
X-Mailer: ELM [version 2.4ME+ PL54 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

Warner Losh writes:
> In message <200007011627.JAA05559@bubba.whistle.com> Archie Cobbs writes:
> : The problem is that the interfaces are not very object oriented
> : (with respect to type), combined with the dynamically loadable code.
> : As an example of the former, all ethernet drivers call if_attach()
> : and ether_attach() when connecting, but only if_detach() when
> : disconnecting. Perhaps they should all only call ether_attach()
> : and ether_detach().
> 
> It should call both.  I thought that pccards all did this, but maybe
> I'm mistaken.

ether_detach() doesn't exist yet.. that's another solution, of
course, to add it and then modify all ethernet drivers to call
ether_detach() right before calling if_detach().. this would be
most consistent with the way things are now I guess.

-Archie

___________________________________________________________________________
Archie Cobbs   *   Whistle Communications, Inc.  *   http://www.whistle.com


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message