From owner-svn-src-head@freebsd.org Sat Feb 22 18:50:06 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 41EE6248F9E; Sat, 22 Feb 2020 18:50:06 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Py7L0CFHz46mn; Sat, 22 Feb 2020 18:50:06 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from [192.168.0.3] (unknown [181.52.72.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: pfg) by smtp.freebsd.org (Postfix) with ESMTPSA id 823D06AFA; Sat, 22 Feb 2020 18:50:05 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Subject: Re: svn commit: r358153 - head/usr.sbin/services_mkdb To: Florian Smeets , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202002200354.01K3s8ib077553@repo.freebsd.org> <03606e17-08fc-f575-95f5-c3c5128bff4f@smeets.xyz> From: Pedro Giffuni Organization: FreeBSD Message-ID: Date: Sat, 22 Feb 2020 13:50:05 -0500 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <03606e17-08fc-f575-95f5-c3c5128bff4f@smeets.xyz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Feb 2020 18:50:06 -0000 On 22/02/2020 11:18, Florian Smeets wrote: > On 20.02.20 04:54, Pedro F. Giffuni wrote: >> Author: pfg >> Date: Thu Feb 20 03:54:07 2020 >> New Revision: 358153 >> URL: https://svnweb.freebsd.org/changeset/base/358153 >> >> Log: >> /etc/services: attempt bring the database to this century. >> >> -smtps 465/tcp #smtp protocol over TLS/SSL (was ssmtp) >> -smtps 465/udp #smtp protocol over TLS/SSL (was ssmtp) > I'm not sure how removals of services have been handled in the past. > This change broke loading of my pf rule set, as I had smtps in there. Excellent! Not that the change broke something but that since we had to revert it we get a second chance to review such things. > I'm not saying that this change is wrong, but I think removing entries > from services can break all kinds of stuff. Not just firewall rule sets, > also scripts and thinking more about it, it will most certainly also > break postfix as it also uses smtps as an alias for port 465 in its > master.cnf According to latest IANA registy: urd                 465        tcp    URL Rendezvous Directory for [Toerless_Eckert] [Toerless_Eckert]                                       SSM submissions         465        tcp    Message Submission over TLS [IESG] [IETF_Chair] 2017-12-12                [RFC8314]                                       protocol igmpv3lite          465        udp    IGMP over UDP for SSM [Toerless_Eckert] [Toerless_Eckert] Anything that can be done upstream to sort this out? > I guess this needs to be at least mentioned in the release notes, and > maybe smtps kept as an alias, and check all the others that were removed? For the time being, we can absolutely keep the legacy value with a conflict note. I wish the services list were a bit easier to maintain for such situations. Pedro.