From owner-freebsd-current Thu Feb 27 17:52:54 1997 Return-Path: Received: (from root@localhost) by freefall.freebsd.org (8.8.5/8.8.5) id RAA01224 for current-outgoing; Thu, 27 Feb 1997 17:52:54 -0800 (PST) Received: from po2.glue.umd.edu (root@po2.glue.umd.edu [129.2.128.45]) by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id RAA01216 for ; Thu, 27 Feb 1997 17:52:52 -0800 (PST) Received: from uplink.eng.umd.edu (uplink.eng.umd.edu [129.2.98.181]) by po2.glue.umd.edu (8.8.5/8.8.5) with ESMTP id UAA01977; Thu, 27 Feb 1997 20:52:49 -0500 (EST) Received: from localhost (chuckr@localhost) by uplink.eng.umd.edu (8.8.5/8.7.3) with SMTP id UAA28087; Thu, 27 Feb 1997 20:52:48 -0500 (EST) X-Authentication-Warning: uplink.eng.umd.edu: chuckr owned process doing -bs Date: Thu, 27 Feb 1997 20:52:48 -0500 (EST) From: Chuck Robey X-Sender: chuckr@uplink.eng.umd.edu To: Bill Fenner cc: FreeBSD current Subject: Re: fixing fsck In-Reply-To: <97Feb27.173846pst.177476@crevenia.parc.xerox.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-current@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk On Thu, 27 Feb 1997, Bill Fenner wrote: > Chuck Robey wrote: > >In dinode.h, all the time related fields, which used to be > >timespec structs (members tv_sec and tv_usec) are now int32_t, which > >doesn't have any logical connection to their time-related usage at all. > >I can't understand the reasoning behind this change. > > If you look carefully at the diffs, the old > > struct timespec di_atime; > > changed to > > int32_t di_atime; > int32_t di_atimensec; > > which makes it relatively clear what happened, especially if you look > at the byte offsets in the comments. di_atime.ts_sec became di_atime, > and di_atime.ts_nsec became di_atimensec. The diff also describes the > reason for this change: > > + * This structure defines the on-disk format of a dinode. Since > + * this structure describes an on-disk structure, all its fields > + * are defined by types with precise widths. Didn't see that. OK, I guess, I can go back to fixing it (unless someone beats me to it). It wasn't a matter of mechanics, it was understanding what was going on, which I now do. Thanks. > > > Bill > ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@eng.umd.edu | communications topic, C programming, and Unix. 9120 Edmonston Ct #302 | Greenbelt, MD 20770 | I run Journey2 and picnic, both FreeBSD (301) 220-2114 | version 3.0 current -- and great FUN! ----------------------------+-----------------------------------------------