Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Jan 2013 13:48:04 -0500
From:      Eitan Adler <eadler@freebsd.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        "src-committers@freebsd.org" <src-committers@freebsd.org>, Xin LI <delphij@gmail.com>, Erik Cederstrand <erik@cederstrand.dk>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, d@delphij.net
Subject:   Re: svn commit: r245494 - head/bin/pwait
Message-ID:  <CAF6rxgm64Xpx2Thad8aL5z_xrY-9HxnJCr_sUhbadbuVMyz7Ng@mail.gmail.com>
In-Reply-To: <201301171035.14799.jhb@freebsd.org>
References:  <201301160503.r0G53qie087155@svn.freebsd.org> <50F6ED68.50602@delphij.net> <CAF6rxgn0sxXbRko0R5nKG%2BySQXqWxxurCGPhzr5t6mpGXHAT2A@mail.gmail.com> <201301171035.14799.jhb@freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 17 January 2013 10:35, John Baldwin <jhb@freebsd.org> wrote:
> No, it is clearly a bug.  It is a waste of time and adds obfuscation (and
> runtime overhead) to go free a bunch of stuff just before a return() from
> main().

It is by-design according to the clang folks.  They have expressed in
interest in offering a knob to change this behavior, but I do not know
the status of it.  That said, I believe Xin's recent commit fixed the
issue of adding an additional free.

IMHO the compiler should also be able to optimize this case of free out.

FWIW I have a very strong feeling of D=C3=A9j=C3=A0 vu here: we have discus=
sed
this exact type of change before.

--=20
Eitan Adler
Source, Ports, Doc committer
Bugmeister, Ports Security teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgm64Xpx2Thad8aL5z_xrY-9HxnJCr_sUhbadbuVMyz7Ng>