Date: Fri, 26 Jul 2019 05:10:42 +0200 From: Emmanuel Vadot <manu@bidouilliste.com> To: Guido Falsi <madpilot@FreeBSD.org> Cc: Emmanuel Vadot <manu@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r350135 - head/share/mk Message-ID: <20190726051042.fcc4f6d969e19fb6f480977b@bidouilliste.com> In-Reply-To: <28eb9717-533e-3d87-0e30-f60317ed97cb@FreeBSD.org> References: <201907191511.x6JFBWVi053537@repo.freebsd.org> <37944eff-6e00-df14-59d3-beae3fa89b6a@FreeBSD.org> <28eb9717-533e-3d87-0e30-f60317ed97cb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 25 Jul 2019 00:17:31 +0200 Guido Falsi <madpilot@FreeBSD.org> wrote: > On 25/07/19 00:14, Guido Falsi wrote: > > On 19/07/19 17:11, Emmanuel Vadot wrote: > >> Author: manu > >> Date: Fri Jul 19 15:11:32 2019 > >> New Revision: 350135 > >> URL: https://svnweb.freebsd.org/changeset/base/350135 > >> > >> Log: > >> bsd.confs.mk: Test the correct value for the destination package > >> > >> Reviewed by: bapt, gjb > >> Differential Revision: https://reviews.freebsd.org/D20961 > >> > > > > Hello, > > > > I don't know the actual workings of this file and have not checked it in > > depth, but this change is causing "make package" to not package > > /etc/rc.d/sshd (and others, all the ones being defined in > > ${group}PACKAGE variables), which are then missing when upgrading machines. > > > > Reverting this change makes packaging things work again. I think this > > change is actually wrong and the previous version was correct. > > /etc/rc.d/sshd is in the FreeBSD-sshd package, the other ones are also in their own package now, I'll check them all to see if that make sense. > After sending this message I also noticed, it causes the spurious > "FreeBSD-zfs" package to be generated again. Not so spurious, it now contains the rc.d zfs related files. I think that I'll remove it anyway, it doesn't make sense. > -- > Guido Falsi <madpilot@FreeBSD.org> -- Emmanuel Vadot <manu@bidouilliste.com> <manu@freebsd.org>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190726051042.fcc4f6d969e19fb6f480977b>