Date: Tue, 3 May 2016 18:06:05 -0600 From: Warner Losh <imp@bsdimp.com> To: "Conrad E. Meyer" <cem@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-head@freebsd.org, Oliver Pinter <oliver.pinter@hardenedbsd.org>, svn-src-all@freebsd.org Subject: Re: svn commit: r298665 - head/sys/dev/aacraid Message-ID: <CANCZdfo-tCXvcJmn5bBp_WAvegsXNz118zmGu5UJv99mCKhD9g@mail.gmail.com> In-Reply-To: <CAG6CVpXXKFwtV0CvjLXA_8mnkP1tCz9ZNf_%2BUpiZc%2BUAAGPyoA@mail.gmail.com> References: <201604262059.u3QKxLDl045059@repo.freebsd.org> <CAPQ4ffvro_5bV_OdH=OLBN8o1Ui%2BvCgi7kBbHjwnoMTAtbo%2B%2BQ@mail.gmail.com> <CAG6CVpWz6phJMzXoZARxUKQg7D1sV3xvdyui8tEftO4eJK1zJg@mail.gmail.com> <A26C4B8A-DD67-4F57-9E26-3DEADE7C82F1@bsdimp.com> <CAG6CVpXXKFwtV0CvjLXA_8mnkP1tCz9ZNf_%2BUpiZc%2BUAAGPyoA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On May 3, 2016 2:38 PM, "Conrad Meyer" <cem@freebsd.org> wrote: > > On Tue, May 3, 2016 at 1:29 PM, Warner Losh <imp@bsdimp.com> wrote: > > > >> On May 3, 2016, at 1:44 PM, Conrad Meyer <cem@FreeBSD.org> wrote: > >> > >> On Tue, May 3, 2016 at 12:00 PM, Oliver Pinter > >> <oliver.pinter@hardenedbsd.org> wrote: > >>> strlcpy instead or adjust the p->vendors size? > >> > >> Neither. The buffer is intentionally not nul-terminated. The > >> coverity reports are false positives. > > > > Then wouldn=E2=80=99t memcmp be better? > > No, memcmp doesn't do anything like strncpy. memcpy wouldn't hurt but > I don't see any reason to change it. It just sounded like these were fixed length fields with no NULs ever. Memcpy would convey that to the reader. But you're right. It isn't a huge thing. Warner > Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfo-tCXvcJmn5bBp_WAvegsXNz118zmGu5UJv99mCKhD9g>