From owner-svn-src-all@freebsd.org Wed Jul 8 22:48:42 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 20C39996E59; Wed, 8 Jul 2015 22:48:42 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 10A7C3667; Wed, 8 Jul 2015 22:48:42 +0000 (UTC) (envelope-from jmg@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.70]) by repo.freebsd.org (8.14.9/8.14.9) with ESMTP id t68Mmf7R098262; Wed, 8 Jul 2015 22:48:41 GMT (envelope-from jmg@FreeBSD.org) Received: (from jmg@localhost) by repo.freebsd.org (8.14.9/8.14.9/Submit) id t68Mmfjc098261; Wed, 8 Jul 2015 22:48:41 GMT (envelope-from jmg@FreeBSD.org) Message-Id: <201507082248.t68Mmfjc098261@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: jmg set sender to jmg@FreeBSD.org using -f From: John-Mark Gurney Date: Wed, 8 Jul 2015 22:48:41 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r285297 - head/sys/crypto/aesni X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 08 Jul 2015 22:48:42 -0000 Author: jmg Date: Wed Jul 8 22:48:41 2015 New Revision: 285297 URL: https://svnweb.freebsd.org/changeset/base/285297 Log: upon further examination, it turns out that _unregister_all already provides the guarantee that no threads will be in the _newsession code.. This is provided by the CRYPTODRIVER lock... This makes the pause unneeded... Modified: head/sys/crypto/aesni/aesni.c Modified: head/sys/crypto/aesni/aesni.c ============================================================================== --- head/sys/crypto/aesni/aesni.c Wed Jul 8 22:46:45 2015 (r285296) +++ head/sys/crypto/aesni/aesni.c Wed Jul 8 22:48:41 2015 (r285297) @@ -196,9 +196,6 @@ aesni_detach(device_t dev) rw_wunlock(&sc->lock); crypto_unregister_all(sc->cid); - /* XXX - wait for anyone in _newsession to leave */ - pause("aniwait", 1); - rw_destroy(&sc->lock); aensi_cleanctx();