From owner-cvs-all@FreeBSD.ORG  Thu Dec 18 08:38:36 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D8D6416A4CE; Thu, 18 Dec 2003 08:38:36 -0800 (PST)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 158BD43D5D; Thu, 18 Dec 2003 08:38:36 -0800 (PST)
	(envelope-from yar@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.12.10/8.12.10) with ESMTP id hBIGcZ0B096671;
	Thu, 18 Dec 2003 08:38:35 -0800 (PST)
	(envelope-from yar@repoman.freebsd.org)
Received: (from yar@localhost)
	by repoman.freebsd.org (8.12.10/8.12.10/Submit) id hBIGcZjn096670;
	Thu, 18 Dec 2003 08:38:35 -0800 (PST)
	(envelope-from yar)
Message-Id: <200312181638.hBIGcZjn096670@repoman.freebsd.org>
From: Yar Tikhiy <yar@FreeBSD.org>
Date: Thu, 18 Dec 2003 08:38:35 -0800 (PST)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/sys/netgraph ng_pppoe.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Dec 2003 16:38:37 -0000

yar         2003/12/18 08:38:35 PST

  FreeBSD src repository

  Modified files:
    sys/netgraph         ng_pppoe.c 
  Log:
  There are two modes of ng_pppoe operation, standard and
  nonstandard.  They differ in the values of certain fields in
  the PPPoE frame.  Previously, ng_pppoe would start in standard
  mode, yet switch to nonstandard one upon reception of a single
  nonstandard frame.  After having done so, ng_pppoe would be unable
  to interact with standard PPPoE peers.  Thus, a DoS condition
  existed that could be triggered by a buggy peer or malicious party.
  
  Since few people have expressed their displeasure WRT this problem,
  the default operation of ng_pppoe is left untouched for now.  However,
  a new value for the sysctl net.graph.nonstandard_pppoe is introduced,
  -1, which will force ng_pppoe stay in standard mode regardless of any
  bogus frames floating around.
  
  PR:             kern/47920
  Submitted by:   Gleb Smirnoff <glebius <at> cell.sick.ru>
  MFC after:      1 week
  
  Revision  Changes    Path
  1.59      +38 -11    src/sys/netgraph/ng_pppoe.c