From owner-freebsd-current@FreeBSD.ORG  Sun Oct 12 16:01:12 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 6BB9E16A4B3
	for <freebsd-current@freebsd.org>;
	Sun, 12 Oct 2003 16:01:12 -0700 (PDT)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 3DB4543FBD
	for <freebsd-current@freebsd.org>;
	Sun, 12 Oct 2003 16:01:11 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.10/8.12.10) with ESMTP id h9CN1749018252;
	Mon, 13 Oct 2003 01:01:08 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: "Kenneth D. Merry" <ken@kdm.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Sun, 12 Oct 2003 16:02:31 MDT."
             <20031012220230.GA20939@panzer.kdm.org> 
Date: Mon, 13 Oct 2003 01:01:07 +0200
Message-ID: <18251.1065999667@critter.freebsd.dk>
cc: freebsd-current@freebsd.org
cc: Steve Kargl <sgk@troutmask.apl.washington.edu>
Subject: Re: cd0 errors during probe? 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Oct 2003 23:01:12 -0000

In message <20031012220230.GA20939@panzer.kdm.org>, "Kenneth D. Merry" writes:

>
>Back when the cd(4) driver used the old slice code, it had a function,
>cdfirsttrackisdata(), that figured out whether the first track was an audio
>or data track.  It would set the flags in the disk structure accordingly to
>tell the slice code whether or not to attempt to read a disklabel from the
>CD.
>
>The code in -stable still works that way.
>
>My guess is that we need something similar again to tell GEOM not to
>attempt to read the first sector of the CD when it's not a data CD.

Or do what the atapi-cd code does:  indicate the true sector size
(2352 bytes) and use whatever "read audio" command is appropriate
for that situation.

I'm somewhat [1] unhappy that the atapi-cd and the scsi_cd present
multitrack CD's in two different ways, and from a POLA [2] perspective
I must say that the /dev/acd%dt%02d devices do make a lot of sense.

Poul-Henning

[1] Not "terribly" because I seldomly use it myself, but the 
inconsistency still bothers me.

[2] Your POLA may vary.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.