From owner-cvs-all@FreeBSD.ORG  Wed Oct 22 21:38:09 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 8DB3416A4C1
	for <cvs-all@FreeBSD.org>; Wed, 22 Oct 2003 21:38:09 -0700 (PDT)
Received: from rootlabs.com (root.org [67.118.192.226])
	by mx1.FreeBSD.org (Postfix) with SMTP id CC3B743FCB
	for <cvs-all@FreeBSD.org>; Wed, 22 Oct 2003 21:38:07 -0700 (PDT)
	(envelope-from nate@rootlabs.com)
Received: (qmail 60974 invoked by uid 1000); 23 Oct 2003 04:38:09 -0000
Date: Wed, 22 Oct 2003 21:38:09 -0700 (PDT)
From: Nate Lawson <nate@root.org>
To: Warner Losh <imp@FreeBSD.org>
In-Reply-To: <20031023034322.2C93616A551@hub.freebsd.org>
Message-ID: <20031022213712.S60963@root.org>
References: <20031023034322.2C93616A551@hub.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/ep if_ep.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2003 04:38:09 -0000

On Wed, 22 Oct 2003, Warner Losh wrote:
>   FreeBSD src repository
>
>   Modified files:
>     sys/dev/ep           if_ep.c
>   Log:
>   Learn basic C.
>           ((uint32_t *) v) + 10 != ((caddr_t) v) + 10
>   so apply the cast later.
>
>   Revision  Changes    Path
>   1.123     +3 -2      src/sys/dev/ep/if_ep.c
>
> Index: src/sys/dev/ep/if_ep.c
> diff -u src/sys/dev/ep/if_ep.c:1.122 src/sys/dev/ep/if_ep.c:1.123
> --- src/sys/dev/ep/if_ep.c:1.122	Sat Oct 18 08:22:43 2003
> +++ src/sys/dev/ep/if_ep.c	Wed Oct 22 20:42:47 2003
> @@ -758,7 +758,7 @@
>  		if (EP_FTST(sc, F_ACCESS_32_BITS)) {
>  			/* default for EISA configured cards */
>  			EP_READ_MULTI_4(sc, EP_W1_RX_PIO_RD_1,
> -			    mtod(m, uint32_t *)+m->m_len,
> +			    (uint32_t *)(mtod(m, caddr_t)+m->m_len),
>  			    lenthisone / 4);
>  			m->m_len += (lenthisone & ~3);
>  			if (lenthisone & 3)

Are you sure you want caddr_t?  Isn't the New Way uintptr_t?

-Nate