Date: Thu, 26 May 2005 11:49:01 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Pav Lucistnik <pav@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/misc/alevt Makefile pkg-descr pkg-plist Message-ID: <20050526114901.GC39880@FreeBSD.org> In-Reply-To: <1117107343.70438.22.camel@pav.hide.vol.cz> References: <200505261051.j4QApDp6070951@repoman.freebsd.org> <1117106958.70438.18.camel@pav.hide.vol.cz> <20050526113355.GA39880@FreeBSD.org> <1117107343.70438.22.camel@pav.hide.vol.cz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, May 26, 2005 at 01:35:43PM +0200, Pav Lucistnik wrote: > Alexey Dokuchaev p??e v ?t 26. 05. 2005 v 11:33 +0000: > > On Thu, May 26, 2005 at 01:29:18PM +0200, Pav Lucistnik wrote: > > > Alexey Dokuchaev p??e v ?t 26. 05. 2005 v 10:51 +0000: > > > > danfe 2005-05-26 10:51:13 UTC > > > > > > > > FreeBSD ports repository > > > > > > > > Modified files: > > > > misc/alevt Makefile pkg-descr pkg-plist > > > > Log: > > > > > > > - Mute directory creation in do-install: target > > > > > > Why? It's nothing filthy to print mkdir, and at least one know what's > > > going on. I was un-muting mkdir's all over the place last year, myself. > > > > Most ports still mute it, from what I can tell. I think that it's reasonable > > enough, just like we don't get CVS commit notifications when create/chechin > > directories. > > > > Still, if I get a feeling that this disturbs people a lot, I will revert this change. > > FWIW, we should explicitly set policy on things like that in Porters' Handbook. > > Oh no, not another policy! I consider it a matter of style and I was > curious about your motivation on this change. :-) Pav, it might be excessive perfectionism, but currently our Ports Collection, despite its great functional state, it not very consistent with respect to knobs handling/names, indentation, and general mark-up. And I kinda fail to see why you don't like policies so badly. Most of us agree that patching/reinplacing things are better done quietly, and I thought that same rule applies to mkdir. On the other hand, unmuting these things has a small benefit of aiding in debugging of broken ports, when error is exhibited only on pointyhat, but local builds succeed. BTW, I agree with your "matter of style" assessment, but the fact that FreeBSD code is so better style(9)-consistent than, say, Linux, is one of the things I love it for. IMHO, "stylificaion/consistensyfication" of our Ports tree is a decent goal to follow, while being low-priority one, indeed. Just my $.02. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050526114901.GC39880>