From owner-freebsd-ports@FreeBSD.ORG Mon Dec 26 22:23:09 2005 Return-Path: X-Original-To: ports@freebsd.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D5BA416A41F for ; Mon, 26 Dec 2005 22:23:09 +0000 (GMT) (envelope-from andy@siliconlandmark.com) Received: from lexi.siliconlandmark.com (lexi.siliconlandmark.com [209.69.98.4]) by mx1.FreeBSD.org (Postfix) with ESMTP id 38B9C43D5C for ; Mon, 26 Dec 2005 22:23:09 +0000 (GMT) (envelope-from andy@siliconlandmark.com) Received: from lexi.siliconlandmark.com (localhost [127.0.0.1]) by lexi.siliconlandmark.com (8.13.3/8.13.3) with ESMTP id jBQMN5vr097088 for ; Mon, 26 Dec 2005 17:23:05 -0500 (EST) (envelope-from andy@siliconlandmark.com) Received: from localhost (andy@localhost) by lexi.siliconlandmark.com (8.13.3/8.13.3/Submit) with ESMTP id jBQMN5jj097085 for ; Mon, 26 Dec 2005 17:23:05 -0500 (EST) (envelope-from andy@siliconlandmark.com) X-Authentication-Warning: lexi.siliconlandmark.com: andy owned process doing -bs Date: Mon, 26 Dec 2005 17:23:05 -0500 (EST) From: Andre Guibert de Bruet To: ports@freebsd.org In-Reply-To: <20051226112327.G68523@lexi.siliconlandmark.com> Message-ID: <20051226165948.I68523@lexi.siliconlandmark.com> References: <20051226112327.G68523@lexi.siliconlandmark.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-Information: Please contact the ISP for more information X-SL-MailScanner: Found to be clean X-SL-SpamCheck: not spam, SpamAssassin (score=-2.599, required 6, autolearn=not spam, BAYES_00 -2.60) X-MailScanner-From: andy@siliconlandmark.com Cc: Subject: Re: [PATCH] /etc/rc: WARNING: $compat5x_enable is not set properly - see rc.conf(5). X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Dec 2005 22:23:10 -0000 On Monday 26 December 2005 17:14, RW wrote: > On Monday 26 December 2005 17:14, Andre Guibert de Bruet wrote: >> I attached a patch that fixes the lack of a default value for this >> variable in /usr/local/etc/rc.d/compat5x.sh (It can be found online as >> well at http://bling.properkernel.com/freebsd/compat5x.rc.d.patch ) > > Should this not default to "YES"? > > compat5x is a library dependence, why should a library dependence need > to be turned-on in rc.conf? Though I appreciate the modularity, I don't understand the need for the knob in this port. Perhaps the script should be renamed to match the naming used in ports like mysql-client and pkgtools for sake of consistency: 000.mysql-client.sh 000.pkgtools.sh Through past experience with the ports system, software that requires something to be run at startup needs to be enabled in rc.conf, which is why I suggested the change that sets compat5x_enable to NO by default in the rc.d script. Seeing that there isn't anything other than ldconfig being run, maybe we should forego rcvar altogether in this script as RW suggested. I posted the trivial one-line patch for that at http://bling.properkernel.com/freebsd/compat5x.norcvar.patch Cheers, Andy PS: Please CC me on replies. I am not subscribed to this list. /* Andre Guibert de Bruet * 6f43 6564 7020 656f 2e74 4220 7469 6a20 */ /* Code poet / Sysadmin * 636f 656b 2e79 5320 7379 6461 696d 2e6e */ /* GSM: +1 734 846 8758 * 5520 494e 2058 6c73 7565 6874 002e 0000 */ /* WWW: siliconlandmark.com * Tormenting bytes since 1980. */