From owner-cvs-all Fri Jan 11 14:55:47 2002 Delivered-To: cvs-all@freebsd.org Received: from elvis.mu.org (elvis.mu.org [192.203.228.196]) by hub.freebsd.org (Postfix) with ESMTP id 0F9B337B416; Fri, 11 Jan 2002 14:55:39 -0800 (PST) Received: by elvis.mu.org (Postfix, from userid 1192) id D6BE710DDFA; Fri, 11 Jan 2002 14:55:38 -0800 (PST) Date: Fri, 11 Jan 2002 14:55:38 -0800 From: Alfred Perlstein To: Dag-Erling Smorgrav Cc: Marcel Moolenaar , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/compat/linux linux_ioctl.c Message-ID: <20020111145538.O7984@elvis.mu.org> References: <200201100536.g0A5aao01807@freefall.freebsd.org> <20020110191209.A318@dhcp01.pn.xcllnt.net> <20020110203918.A440@dhcp01.pn.xcllnt.net> <20020111112851.A2103@kayak.xcllnt.net> <20020111122534.K7984@elvis.mu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from des@ofug.org on Fri, Jan 11, 2002 at 11:40:46PM +0100 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Dag-Erling Smorgrav [020111 14:46] wrote: > Alfred Perlstein writes: > > * Dag-Erling Smorgrav [020111 12:20] wrote: > > > Since when does "talking it over first" mean "commit a patch without > > > discussing it with the person who wrote the code it changes"? > > > Especially when similar patches have been suggested, discussed, and > > > rejected before (see for instance the audit trail for PR 26546). > > You don't give a reason for your: > > "Partial fix committed, more work remains to be done." > > See the log entry for revision 1.68 of linux_ioctl.c, and succeeding > revisions. The revision in which the fix was incorperated should have been logged in the PR. > > It would make both the PR originator as well as fellow developers > > understand why and how you are doing things. > > Both ambrisko (who submitted the PR) and marcel were involved in the > development of the patches I *did* commit. Then you're most likely in the right. Your attitude however works hard against that. Perhaps if you would approach these situations with a bit more flexibility/gentelness things would work out a bit smoother. -- -Alfred Perlstein [alfred@freebsd.org] 'Instead of asking why a piece of software is using "1970s technology," start asking why software is ignoring 30 years of accumulated wisdom.' Tax deductable donations for FreeBSD: http://www.freebsdfoundation.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message