From owner-cvs-all@FreeBSD.ORG  Thu Apr  3 02:26:23 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 276BE37B401; Thu,  3 Apr 2003 02:26:23 -0800 (PST)
Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 1BEE143FAF; Thu,  3 Apr 2003 02:26:21 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from katana.zip.com.au (katana.zip.com.au [61.8.7.246])
	by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id UAA11984;
	Thu, 3 Apr 2003 20:26:11 +1000
Date: Thu, 3 Apr 2003 20:26:05 +1000 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: Marcel Moolenaar <marcel@xcllnt.net>
In-Reply-To: <20030403093800.GA68012@dhcp01.pn.xcllnt.net>
Message-ID: <20030403200459.H30311@gamplex.bde.org>
References: <200304030513.h335DR60079544@repoman.freebsd.org>
	<20030403055049.GA67232@dhcp01.pn.xcllnt.net>
	<20030403085350.GA37174@sunbay.com>
	<20030403093800.GA68012@dhcp01.pn.xcllnt.net>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: Juli Mallett <jmallett@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: Ruslan Ermilov <ru@FreeBSD.org>
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.ctable.c
 talkd.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 03 Apr 2003 10:26:23 -0000

On Thu, 3 Apr 2003, Marcel Moolenaar wrote:

> On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote:
> > >
> > How's this bugfix?
> >
> > %%%
> > Index: bsd.sys.mk
> > ===================================================================
> > RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v
> > retrieving revision 1.12
> > diff -u -r1.12 bsd.sys.mk
> > --- bsd.sys.mk	31 Mar 2003 13:10:51 -0000	1.12
> > +++ bsd.sys.mk	3 Apr 2003 08:48:40 -0000
> > @@ -25,7 +25,7 @@
> >  .  if ${WARNS} > 3
> >  CFLAGS		+=	-Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align
> >  .  endif
> > -.  if ${WARNS} > 4
> > +.  if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0)
> >  CFLAGS		+=	-Wuninitialized
> >  .  endif
> >  # BDECFLAGS
> > %%%
>
> Should work in most cases, but beware DEBUG_FLAGS. The above does not
> catch the case where DEBUG_FLAGS is defined to something like "-O0 -g".
> I think this is a reasonable use of DEBUG_FLAGS.
>
> \begin{log}
> dhcp01% setenv DEBUG_FLAGS "-O0 -g"
> dhcp01% setenv CFLAGS -O
> dhcp01% make
> cc -O -mcpu=pentiumpro -I/usr/local/src/fpi/cpu/..  -O0 -g -Wsystem-headers -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized  -c decode.c
> cc1: warnings being treated as errors
> cc1: warning: -Wuninitialized is not supported without -O
> *** Error code 1
> \end{log}

The patch works for me, as it should since ${DEBUG_FLAGS} is added to
CFLAGS before including bsd.sys.mk in at least bsd.prog.mk.  Similarly
for COPTS, except it is actually documented in mk/bsd.README.

There are some other minor ordering problems.  -Winitialized is not set
for "-O -O0 -O" in ${CFLAGS}, and there may be hackish makefiles that set
CFLAGS after including <bsd.prog.mk>.

Bruce