From owner-cvs-all@FreeBSD.ORG  Fri Feb 23 21:15:19 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id DF1F416A542;
	Fri, 23 Feb 2007 21:15:19 +0000 (UTC)
	(envelope-from jhein@timing.com)
Received: from Daffy.timing.com (daffy.timing.com [206.168.13.218])
	by mx1.freebsd.org (Postfix) with ESMTP id A1E9F13C4A8;
	Fri, 23 Feb 2007 21:15:19 +0000 (UTC)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (gromit.timing.com [206.168.13.209])
	by Daffy.timing.com (8.13.1/8.13.1) with ESMTP id l1NKbDke040653;
	Fri, 23 Feb 2007 13:37:13 -0700 (MST)
	(envelope-from jhein@timing.com)
Received: from gromit.timing.com (localhost [127.0.0.1])
	by gromit.timing.com (8.13.8/8.13.8) with ESMTP id l1NKb7NQ068374;
	Fri, 23 Feb 2007 13:37:07 -0700 (MST)
	(envelope-from jhein@gromit.timing.com)
Received: (from jhein@localhost)
	by gromit.timing.com (8.13.8/8.13.8/Submit) id l1NKb7wX068371;
	Fri, 23 Feb 2007 13:37:07 -0700 (MST) (envelope-from jhein)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-ID: <17887.20595.540648.699149@gromit.timing.com>
Date: Fri, 23 Feb 2007 13:37:07 -0700
From: John E Hein <jhein@timing.com>
To: John Baldwin <jhb@FreeBSD.org>
In-Reply-To: <200702231625.l1NGP86A029885@repoman.freebsd.org>
References: <200702231625.l1NGP86A029885@repoman.freebsd.org>
X-Mailer: VM 7.19 under Emacs 22.0.93.1
X-Virus-Scanned: ClamAV version 0.90,
	clamav-milter version devel-120207 on Daffy.timing.com
X-Virus-Status: Clean
X-Spam-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,
	DK_POLICY_SIGNSOME autolearn=disabled version=3.1.8
X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on Daffy.timing.com
Cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/compat/ndis kern_ndis.c
	src/sys/dev/acpica/Osd
	OsdSchedule.c src/sys/dev/ata ata-all.c atapi-cd.c atapi-tape.c
	src/sys/dev/ppc ppc.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Feb 2007 21:15:20 -0000

John Baldwin wrote at 16:25 +0000 on Feb 23, 2007:
 > jhb         2007-02-23 16:25:08 UTC
 > 
 >   FreeBSD src repository
 > 
 >   Modified files:
 >     sys/compat/ndis      kern_ndis.c 
 >     sys/dev/acpica/Osd   OsdSchedule.c 
 >     sys/dev/ata          ata-all.c atapi-cd.c atapi-tape.c 
 >     sys/dev/ppc          ppc.c 
 >   Log:
 >   Use 'pause' in several places rather than trying to tsleep() on NULL (which
 >   triggers a KASSERT) or local variables.  In the case of kern_ndis, the
 >   tsleep() actually used a common sleep address (curproc) making it
 >   susceptible to a premature wakeup.

Nice.  Maybe you should pass in priority so pause(9) users don't
always wake up at PRI_MIN.

If not, PZERO might be a more sensible default perhaps.

PCATCH complicates this slightly since pause(9) currently returns
nothing, but I could see cases where users might want PCATCH.