From owner-freebsd-current Fri Oct 4 14:30:57 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B46D537B401 for ; Fri, 4 Oct 2002 14:30:55 -0700 (PDT) Received: from azazel.ipv6.hackerheaven.org (ipv6.hackerheaven.org [80.126.0.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id 6815543E42 for ; Fri, 4 Oct 2002 14:30:54 -0700 (PDT) (envelope-from coolvibe@hackerheaven.org) Received: from azazel.ipv6.hackerheaven.org (localhost [127.0.0.1]) by azazel.ipv6.hackerheaven.org (8.12.6/8.12.5) with ESMTP id g94LUeG2018487; Fri, 4 Oct 2002 23:30:40 +0200 Received: (from coolvibe@localhost) by azazel.ipv6.hackerheaven.org (8.12.6/8.12.5/Submit) id g94LUePc018486; Fri, 4 Oct 2002 23:30:40 +0200 Date: Fri, 4 Oct 2002 23:30:40 +0200 From: Emiel Kollof To: Peter Wemm Cc: Poul-Henning Kamp , n0go013 , current Subject: Re: [ GEOM tests ] disklabel warnings and vinum drives lost Message-ID: <20021004213040.GA12938@hackerheaven.org> References: <35389.1033748850@critter.freebsd.dk> <20021004211157.378592A896@canning.wemm.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021004211157.378592A896@canning.wemm.org> User-Agent: Mutt/1.4i X-Mailer: Mutt 1.3.23i (2001-10-09) X-Editor: Vim http://www.vim.org/ X-Info: http://www.hackerheaven.org/ X-Info2: http://www.cmdline.org/ X-Info3: http://www.coolvibe.org/ X-message-flag: Out of cheese error! Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG * Peter Wemm (peter@wemm.org) wrote: > vinum is so much unbelievable stuff in it. Consider this stuff: > > sys/dev/vinum/vinumio.c: > [Biiiiig ugly if/else fallthrough snipped] Ick... Which sick person wrote that? switch() and cpp macros usually do wonders in cases like these in terms of readability/maintainability at least. > It goes *way* downhill from there. :-( And I stay away from vinum just a little longer after having seen and verified this... [snip] > This crud has *got* to be taken out and shot, then reworked to do it > properly. Amen! (and no, I'm not volunteering. I don't mind cleaning up code, but there are limits to what crud I touch) Cheers, Emiel -- When the English language gets in my way, I walk over it. -- Billy Sunday To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message