From nobody Mon Oct 18 10:28:25 2021 X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id CEC7D17F067C; Mon, 18 Oct 2021 10:28:34 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HXtPt5KW3z4v3d; Mon, 18 Oct 2021 10:28:34 +0000 (UTC) (envelope-from tobias.kortkamp@gmail.com) Received: by mail-ed1-f47.google.com with SMTP id ec8so69225058edb.6; Mon, 18 Oct 2021 03:28:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yU6RvKa4jBbgFfGHpp7dZ1iPKz8pFJqYXK1AbXD/z9A=; b=c18XQb5eoNATorz3zIAOaftbI0Z+x3ORhQW+tnMD2Jn0oRfKXiREwv1VLFzLxsxk4g MCiCnwdDLy4d8LARWGAiuB2SAvIuzjoFuN6bK3145DEjf4mtdh2AReniOhUZVdSNdFYx Xm1ftnT4xq+Ewm+xLu/0TKbn9QABVptHhpTd3hfYeWbpnoDRPVZSMriSJELpidwkgSM7 EXPgivPnXCaknKjPCMf+IGLJ+gJ3+dmBstGSYS/5xyGcyI/kU+ceWWt0P9yy69VvGMNW ugoyexQqEPHwuMfTivnit4Hn1yW6Fjj0uDlg6SuqETtDKlZl0T//1XgXxHEVNiIK+16L M9cA== X-Gm-Message-State: AOAM5329E2TySPpvU8dk69mJfr3fmkGg+epTo9bXO7VGPXWGzf+1TB1I aiuONKSs2ESCp1MvRZ3P2l8+RIfHrGQ= X-Google-Smtp-Source: ABdhPJxWh/609aIme79bakqF/XcemaIsfrCfwhLoNFF7V79XnvUDaTU+CHIo++2+pza+795FSe8mRQ== X-Received: by 2002:a17:906:c7c1:: with SMTP id dc1mr29535286ejb.6.1634552908125; Mon, 18 Oct 2021 03:28:28 -0700 (PDT) Received: from loki.kortkamp.xyz (p200300e497028e0002155dfffe002610.dip0.t-ipconnect.de. [2003:e4:9702:8e00:215:5dff:fe00:2610]) by smtp.gmail.com with ESMTPSA id y21sm8610580ejk.30.2021.10.18.03.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Oct 2021 03:28:27 -0700 (PDT) Date: Mon, 18 Oct 2021 12:28:25 +0200 From: Tobias Kortkamp To: Bernhard Froehlich Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: f8daab173840 - main - devel/kf5-kio: Remove extra CPE_VENDOR and inherit from USES=kde instead Message-ID: References: <202110180834.19I8YDmZ018027@gitrepo.freebsd.org> List-Id: Commit messages for all branches of the ports repository List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-ports-all@freebsd.org X-BeenThere: dev-commits-ports-all@freebsd.org MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="v/0W4Okg88BKFRLd" Content-Disposition: inline In-Reply-To: <202110180834.19I8YDmZ018027@gitrepo.freebsd.org> X-Rspamd-Queue-Id: 4HXtPt5KW3z4v3d X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[] X-ThisMailContainsUnwantedMimeParts: N --v/0W4Okg88BKFRLd Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Oct 18, 2021 at 08:34:13AM +0000, Bernhard Froehlich wrote: > -USES=3D cmake compiler:c++11-lib cpe desktop-file-utils \ > - gettext gnome kde:5 qt:5 ssl tar:xz > -CPE_VENDOR=3D kde > +USES=3D cmake compiler:c++11-lib desktop-file-utils \ > + gettext gnome kde:5 cpe qt:5 ssl tar:xz Wouldn't it better to change USES=3Dcpe a little to set variables later in _USES_POST? Then other USES can set their own defaults for CPE_* and we don't create a USES ordering problem that contributors have to be surprised by. diff --git a/Mk/Uses/cpe.mk b/Mk/Uses/cpe.mk index 410a05c6e437..d88aa06c17f8 100644 --- a/Mk/Uses/cpe.mk +++ b/Mk/Uses/cpe.mk @@ -18,6 +18,11 @@ =20 .if !defined(_INCLUDE_USES_CPE_MK) _INCLUDE_USES_CPE_MK=3D yes +_USES_POST+=3D cpe +.endif + +.if defined(_POSTMKINCLUDED) && !defined(_INCLUDE_USES_CPE_POST_MK) +_INCLUDE_USES_CPE_POST_MK=3D yes =20 CPE_PART ?=3D a CPE_PRODUCT ?=3D ${PORTNAME:tl} --v/0W4Okg88BKFRLd Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGTBAEBCgB9FiEElXvTEJc6ePgdQuobpPCftzzFH2EFAmFtTEdfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDk1 N0JEMzEwOTczQTc4RjgxRDQyRUExQkE0RjA5RkI3M0NDNTFGNjEACgkQpPCftzzF H2F1LQf+NMgzLZQcMQjtRVDNGY378sgxbEAnROnvc3jueIvyByFM07Eo0fmb/EfB hs9gWmGXZouKkUNJmH020cmQ/Xqojhzs+QJnThB46zqHbrr/gfuyRdwiI6eLBIbD qNlpmxn/5VZxfxfD2ElrV92UcoT0GlX99Vd8KKeUyrRDKXuvwOVEHoO9iS4x58fC oqtJnEodLIvLcjb+Yo9jej2ma2igaFIBYCTWjF+TCED+pYA+qX3d4FOqSocvcpcr YenxXJdZ1lCNa2arhhvfz7BE8svXGO+B1+G7L/59spIJnLSc7UYtrn1x8VK6RDBe lEj2H0vbTzJzRZiUfyMzNvyy+xgk9Q== =ZqiF -----END PGP SIGNATURE----- --v/0W4Okg88BKFRLd--