Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 27 May 2019 16:34:34 -0600
From:      Ian Lepore <ian@freebsd.org>
To:        rgrimes@freebsd.org, Alexey Dokuchaev <danfe@freebsd.org>
Cc:        Konstantin Belousov <kostikbel@gmail.com>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r232071 - head/sys/vm
Message-ID:  <b96bcf5fceb677d8996a44fae9217fbff5be4f88.camel@freebsd.org>
In-Reply-To: <201905272134.x4RLY9oO012473@gndrsh.dnsmgr.net>
References:  <201905272134.x4RLY9oO012473@gndrsh.dnsmgr.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2019-05-27 at 14:34 -0700, Rodney W. Grimes wrote:
> I just ask that before a change be made that starts from some
> static analysis tool that a formal code review occur before
> the change is committed.

In a word:  No.

We're not talking about some inexperienced coder committing dumb fixes
to silence warnings here.  What I've seen so far is that fixes are
being committed by the people who originally wrote or currently
maintain the code in question.  Nothing bad is happening, so nothing
about the process needs to be fixed or changed in any way.

Process for process' sake is just obstruction.

-- Ian





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?b96bcf5fceb677d8996a44fae9217fbff5be4f88.camel>