From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Dec 15 18:50:29 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4FDA916A4CE for ; Wed, 15 Dec 2004 18:50:29 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3407443D2D for ; Wed, 15 Dec 2004 18:50:29 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iBFIoTPx054297 for ; Wed, 15 Dec 2004 18:50:29 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iBFIoTRu054296; Wed, 15 Dec 2004 18:50:29 GMT (envelope-from gnats) Date: Wed, 15 Dec 2004 18:50:29 GMT Message-Id: <200412151850.iBFIoTRu054296@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Stefan Walter Subject: Re: ports/75119: [MAINTAINER] graphics/cal3d: fix plist X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Stefan Walter List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Dec 2004 18:50:29 -0000 The following reply was made to PR ports/75119; it has been noted by GNATS. From: Stefan Walter To: Greg Lewis Cc: freebsd-gnats-submit@freebsd.org Subject: Re: ports/75119: [MAINTAINER] graphics/cal3d: fix plist Date: Wed, 15 Dec 2004 19:45:01 +0100 --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi, Greg Lewis, 15.12.04, 18:35h CET: > This patch appears to be incorrect. The libdata/pkgconfig directory is > used by a lot of ports, so assuming you can unequivocally remove it is > incorrect and yields an error such as: > > pkg_delete: unable to completely remove directory '/usr/local/libdata/pkgconfig' > pkg_delete: couldn't entirely delete package (perhaps the packing list is incorrectly specified?) > > when applied. Yes, I was aware of that, but it seemed like the best thing to do to me. > A better patch would be to rely on pkgconfig which creates and deletes > this directory. E.g. add > > USE_GNOME= pkgconfig > > to the Makefile. What do you think? I didn't know about this option at all, and I cannot currently test its functionality here because I do not want to deinstall pkgconfig and all the packages that depend on it. ;) Nevertheless it looks reasonable and I assume that you're right, so I've attached a corrected patch. Thanks, Stefan, who needs a larger hard drive to set up a jail and more time for testing ports stuff... --2oS5YaxWCcQjTEyO Content-Type: text/plain; charset=us-ascii Content-Disposition: attachment; filename="cal3d-pkgconfig.patch" diff -ruN cal3d.old/Makefile cal3d/Makefile --- cal3d.old/Makefile Wed Dec 15 19:13:16 2004 +++ cal3d/Makefile Wed Dec 15 19:13:36 2004 @@ -15,6 +15,7 @@ COMMENT= Skeletal based 3d character animation library written in C++ USE_BZIP2= yes +USE_GNOME= pkgconfig USE_AUTOMAKE_VER= 19 USE_AUTOHEADER_VER= 259 USE_LIBTOOL_VER= 15 --2oS5YaxWCcQjTEyO--