From owner-freebsd-ports Sat Mar 24 22:23:33 2001 Delivered-To: freebsd-ports@freebsd.org Received: from rbn-gw.bgtu.debryansk.ru (rbn-gw.bgtu.debryansk.ru [62.76.89.2]) by hub.freebsd.org (Postfix) with ESMTP id 90F7337B71A for ; Sat, 24 Mar 2001 22:23:29 -0800 (PST) (envelope-from kapr@acm.org) Received: from server.bitmcnit.bryansk.su (root@bitmcnit.bryansk.su [192.168.121.2]) by rbn-gw.bgtu.debryansk.ru (8.11.2/8.11.2) with ESMTP id f2P6M9311564; Sun, 25 Mar 2001 10:22:10 +0400 Received: (from uucp@localhost) by server.bitmcnit.bryansk.su (8.9.3/8.9.3) with UUCP id JAA25370; Sun, 25 Mar 2001 09:15:41 +0400 Received: (from alex@localhost) by kapran.bitmcnit.bryansk.su (8.11.3/8.11.3) id f2P6GwE01437; Sun, 25 Mar 2001 10:16:58 +0400 (MSD) (envelope-from kapr@acm.org) X-Authentication-Warning: kapran.bitmcnit.bryansk.su: alex set sender to kapr@acm.org using -f Date: Sun, 25 Mar 2001 10:16:58 +0400 From: Alex Kapranoff To: Kris Kennaway Cc: ports@freebsd.org Subject: Re: Conditionalizing MACHINE_CPU checks Message-ID: <20010325101657.C1202@kapran.bitmcnit.bryansk.su> References: <20010319091353.A4146@kapran.bitmcnit.bryansk.su> <20010324154609.A42192@xor.obsecurity.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010324154609.A42192@xor.obsecurity.org>; from kris@obsecurity.org on Sat, Mar 24, 2001 at 03:46:09PM -0800 X-Operating-System: FreeBSD 5.0-CURRENT i386 Organization: Internal Mongolia Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Sat, Mar 24, 2001 at 03:46:09PM -0800, Kris Kennaway wrote: > On Mon, Mar 19, 2001 at 09:13:53AM +0300, Alex Kapranoff wrote: > > Good day to all. > > > > Do I really need to wrap MACHINE_CPU tests (like ${MACHINE_CPU:Mmmx}) > > inside ${OSVERSION} >= 500018 tests? > > It's also in RELENG_4 now, so you should use check for > > ${OSVERSION} >= 500018 || ( ${OSVERSION} < 500000 && ${OSVERSION} >= 430000 ) How about defined(MACHINE_CPU) instead? > > E.g. is it ok to do tests in this way: > > > > .if defined(WITH_MMX) || ${MACHINE_CPU:Mmmx} > > SRCS+= mmx.c > > .elif ${ARCH} == "i386" > > @${ECHO_MSG} "You can define WITH_MMX to use MMX instructions" > > .endif > > I'd prefer to keep it under an .if OSVERSION test, so it becomes > easier to just chop out the .else section when we stop supporting > systems older than ${OSVERSION} == 430000 Point taken. -- Alex Kapranoff, Voice: +7(0832)791845 We've lived 2001 hours in the brand new millenium... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message