Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 23 Jul 2013 16:04:04 -0600
From:      "Justin T. Gibbs" <gibbs@FreeBSD.org>
To:        =?iso-8859-1?Q?Ulrich_Sp=F6rlein?= <uqs@freebsd.org>
Cc:        scsi@freebsd.org
Subject:   Re: Please review patch for aic7xxx_pci.c
Message-ID:  <DB1AD5E3-8108-46EF-AEC0-195AEEF7FCEC@FreeBSD.org>
In-Reply-To: <20130723214126.GG9030@acme.spoerlein.net>
References:  <20130716094927.GA9030@acme.spoerlein.net> <20130723071129.GD9030@acme.spoerlein.net> <FBF11F26-4083-4F7C-AEC6-054E369A1A25@FreeBSD.org> <20130723204530.GE9030@acme.spoerlein.net> <86E509ED-694D-49B0-A3D9-C9C7B71F67CE@FreeBSD.org> <20130723214126.GG9030@acme.spoerlein.net>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
On Jul 23, 2013, at 3:41 PM, Ulrich Sp=F6rlein <uqs@freebsd.org> wrote:

> On Tue, 2013-07-23 at 15:15:53 -0600, Justin T. Gibbs wrote:
>> On Jul 23, 2013, at 2:45 PM, Ulrich Sp=F6rlein <uqs@freebsd.org> =
wrote:
>>=20
>>> Thanks, but maybe it's better to have the discussion here.
>>>=20
>>> You wrote:
>>> The difference in the argument order between the declaration and =
definition is
>>> likely what led to this programming error. Your patch should also =
correct the
>>> argument reversal in the declaration of ahc_9005_subdevinfo_valid().
>>>=20
>>> The argument order you've used seems the best choice since it =
matches what is
>>> used in ahc_compose_id().
>>>=20
>>>=20
>>>=20
>>> I'm not sure that reversing the arguments in the function definition =
is
>>> the right way. This would make the patch a no-op.
>>=20
>> Read the quote again.  I said change the "declaration", not the
>> "definition".  To be extremely clear, the code currently looks like
>> this:
>=20
> D'oh, that's what I get for reading too fast. I've opted to change the
> function definition, in the end, so that declaration, definition and
> call-site are in sync, see
> =
https://github.com/uqs/freebsd-head/commit/e699b2fde01f235a22e1125e9f3aef1=
6623b512f
>=20
> Thanks!
> Uli

But now the order of the arguments does not match ahc_compose_id().

It seems to me that we want to only have a single convention in how this
data is passed to functions.

--
Justin=



Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?DB1AD5E3-8108-46EF-AEC0-195AEEF7FCEC>