Date: Mon, 6 Mar 2017 19:31:38 -0800 (PST) From: "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net> To: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> Cc: rgrimes@freebsd.org, Ngie Cooper <ngie@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org Subject: Re: svn commit: r314819 - stable/11/lib/libutil Message-ID: <201703070331.v273VcBc092092@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <699FBEE3-2379-414E-9E50-C3F726212949@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[ Charset UTF-8 unsupported, converting... ] > > > On Mar 6, 2017, at 19:10, Ngie Cooper (yaneurabeya) <yaneurabeya@gmail.com> wrote: > > > >> > >> On Mar 6, 2017, at 19:00, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: > >> > >> [ Charset UTF-8 unsupported, converting... ] > >>> Author: ngie > >>> Date: Tue Mar 7 01:58:39 2017 > >>> New Revision: 314819 > >>> URL: https://svnweb.freebsd.org/changeset/base/314819 > >>> > >>> Log: > >>> MFC r313438: > >>> > >>> Clean up trailing and leading whitespace for variables to make it > >>> consistent with the rest of the file and style.Makefile(9) a bit > >>> more > >>> > >>> Modified: > >>> stable/11/lib/libutil/Makefile > >>> Directory Properties: > >>> stable/11/ (props changed) > >>> > >>> Modified: stable/11/lib/libutil/Makefile > >>> ============================================================================== > >>> --- stable/11/lib/libutil/Makefile Tue Mar 7 01:52:56 2017 (r314818) > >>> +++ stable/11/lib/libutil/Makefile Tue Mar 7 01:58:39 2017 (r314819) > >>> @@ -35,7 +35,7 @@ MAN+= expand_number.3 flopen.3 fparseln. > >>> property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 \ > >>> _secure_path.3 trimdomain.3 uucplock.3 pw_util.3 > >>> MAN+= login.conf.5 > >>> -MLINKS+= kld.3 kld_isloaded.3 kld.3 kld_load.3 > >>> +MLINKS+=kld.3 kld_isloaded.3 kld.3 kld_load.3 > >>> MLINKS+=login_auth.3 auth_cat.3 login_auth.3 auth_checknologin.3 > >>> MLINKS+=login_cap.3 login_close.3 login_cap.3 login_getcapbool.3 \ > >> > >> Thats actually counter style.Makefile(9), Normally you have a tab here, > >> or a space should the variable name extend beyond column 9. > >> > >>> login_cap.3 login_getcaplist.3 login_cap.3 login_getcapnum.3 \ > >>> @@ -57,9 +57,9 @@ MLINKS+=pidfile.3 pidfile_close.3 \ > >>> pidfile.3 pidfile_open.3 \ > >>> pidfile.3 pidfile_remove.3 \ > >>> pidfile.3 pidfile_write.3 > >>> -MLINKS+= property.3 property_find.3 property.3 properties_free.3 > >>> -MLINKS+= property.3 properties_read.3 > >>> -MLINKS+= pty.3 forkpty.3 pty.3 openpty.3 > >>> +MLINKS+=property.3 property_find.3 property.3 properties_free.3 > >>> +MLINKS+=property.3 properties_read.3 > >>> +MLINKS+=pty.3 forkpty.3 pty.3 openpty.3 > >> > >> Ditto. > > > > Yeah, I tried to leave things alone (except is surrounding areas for the following change), but I?ll go and hack away at the Makefile some more. > > Thanks, > > Actually, on second thought, I?m not going to modify the Makefile to just introduce gratuitous whitespace. If I need to touch this again, I?ll do it, but it doesn?t make sense churning over this Makefile like that (it?s a mishmash of different ?styles?). I am less concered about fixing this and more concerned about making sure you understood what the actual sytle.Makeilfe(9) rules are becuase it appeared that given the counter style changes you thought there should be no white space after VAR= in a Makefile. You probably understand that better than most and this is just a poor choice of words in the commit message. > -Ngie -- Rod Grimes rgrimes@freebsd.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201703070331.v273VcBc092092>