From owner-freebsd-arch Fri Oct 5 20:14:10 2001 Delivered-To: freebsd-arch@freebsd.org Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by hub.freebsd.org (Postfix) with ESMTP id 1677B37B407 for ; Fri, 5 Oct 2001 20:14:07 -0700 (PDT) Received: from fledge.watson.org (robert@fledge.pr.watson.org [192.0.2.3]) by fledge.watson.org (8.11.6/8.11.5) with SMTP id f963DkB60137; Fri, 5 Oct 2001 23:13:46 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Fri, 5 Oct 2001 23:13:45 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Dag-Erling Smorgrav Cc: Peter Wemm , arch@FreeBSD.ORG Subject: Re: Removing ptrace(2)'s dependency on procfs(5) In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG I've already delivered some comments to you out-of-band, but here are a couple more: (1) Actually, this is a duplicate of an out-of-band one: using procfs_rwmem() as a function name in sys_process.c still jibes: are you sure you don't want to rename it now rather than waiting? :-) (2) For the security check: + if (uap->req != PT_TRACE_ME && (error = p_candebug(curp, p))) { + PROC_UNLOCK(p); + return (error); + } Instead, modify p_candebug() to allow debugging of p1 by p1 always. Structuring the P_SYSTEM check that way is fine, as that's a syntax check, but since this case exempts the security check if it's PT_TRACE_ME, I'd rather we modify the security check. Note that one benefit to doing it this way is that if the admin disables debugging globally using the existing policy sysctl, it also disables it for the current process. Otherwise, looks good to me. No doubt once it's committed, there will be some further tweaks, but this is a cleanup I'm very happy to see happen. Thanks! Robert N M Watson FreeBSD Core Team, TrustedBSD Project robert@fledge.watson.org NAI Labs, Safeport Network Services On 5 Oct 2001, Dag-Erling Smorgrav wrote: > Dag-Erling Smorgrav writes: > > I've put up a new patch that places the prototypes in ptrace.h rather > > than add a new header: > > I left one instance of #include in, so this patch > wouldn't build. The correct (and tested) patch is: > > http://people.freebsd.org/~des/software/ptrace-20011005b.diff > > DES > -- > Dag-Erling Smorgrav - des@ofug.org > > To Unsubscribe: send mail to majordomo@FreeBSD.org > with "unsubscribe freebsd-arch" in the body of the message > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message