Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 06 May 2006 00:53:47 -0700
From:      Pascal Hofstee <caelian@gmail.com>
To:        =?ISO-8859-1?Q?Jo=E3oBR?= <joao@matik.com.br>
Cc:        freebsd-amd64@freebsd.org
Subject:   Re: FreeBSD nfe driver for NVIDIA nForce network adapter
Message-ID:  <1146902027.1357.25.camel@synergy.odyssey.homeunix.org>
In-Reply-To: <445C5363.2070205@matik.com.br>
References:  <44506B8B.4090605@se.hiroshima-u.ac.jp> <200605011117.16519.joao@matik.com.br> <2923.210.250.105.90.1146838969.squirrel@www.se.hiroshima-u.ac.jp> <445B7279.2050103@matik.com.br> <4354.210.250.105.90.1146846584.squirrel@www.se.hiroshima-u.ac.jp> <445C5363.2070205@matik.com.br>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2006-05-06 at 04:42 -0300, JoćoBR wrote:
> Shigeaki Tagashira wrote:
> hum, and this
> 
> #ifdef HAVE_KERNEL_OPTION_HEADERS
> #include "opt_device_polling.h"
> #endif

I noticed a few spots in the code that are essentially temporary
workarounds to the driver not being imported into the physical /usr/src
hierarchy.

The above quoted ifdef construct would be one of those. As soon as this
driver actually hits the actual /usr/src tree .. all these "shims" like
the current manual define of DEVICE_POLLING and similar constructs can
be removed.

But as long as we're building from a directory outside of /usr/src
proper ... constructs like the above quoted HAVE_KERNEL_OPTION_HEADERS
simply don't work as supposed to.

At least that's my understanding of it all :)

-- 
  Pascal Hofstee





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1146902027.1357.25.camel>