From owner-svn-src-head@freebsd.org  Fri Mar  9 22:31:33 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 77E86F2BD61
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Fri,  9 Mar 2018 22:31:33 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id F300A7128E
 for <svn-src-head@freebsd.org>; Fri,  9 Mar 2018 22:31:32 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: 7fdbfb70-23e9-11e8-b951-f99fef315fd9
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound2.ore.mailhop.org (Halon) with ESMTPSA
 id 7fdbfb70-23e9-11e8-b951-f99fef315fd9;
 Fri, 09 Mar 2018 22:30:42 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w29MVUBl008952;
 Fri, 9 Mar 2018 15:31:30 -0700 (MST) (envelope-from ian@freebsd.org)
Message-ID: <1520634689.84937.74.camel@freebsd.org>
Subject: Re: svn commit: r328013 - head/sbin/fsck_ffs
From: Ian Lepore <ian@freebsd.org>
To: Mark Johnston <markj@FreeBSD.org>, David Bright <dab@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Date: Fri, 09 Mar 2018 15:31:29 -0700
In-Reply-To: <20180309220940.GG6174@raichu>
References: <201801151925.w0FJPCKA019434@repo.freebsd.org>
 <20180309220940.GG6174@raichu>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 09 Mar 2018 22:31:33 -0000

On Fri, 2018-03-09 at 17:09 -0500, Mark Johnston wrote:
> On Mon, Jan 15, 2018 at 07:25:11PM +0000, David Bright wrote:
> > 
> > Author: dab
> > Date: Mon Jan 15 19:25:11 2018
> > New Revision: 328013
> > URL: https://svnweb.freebsd.org/changeset/base/328013
> > 
> > Log:
> >   Exit fsck_ffs with non-zero status when file system is not repaired.
> >   
> > [...]
> etc/rc.d/fsck doesn't know how to interpret the new exit code and now
> just drops to a single-user shell when it is encountered. This is
> happening to me semi-regularly when my test systems crash, especially
> when I test kernel panic handling. :)
> 
> Is there any reason etc/rc.d/fsck shouldn't automatically retry (up to
> some configurable number of retries) when the new error code is seen?
> The patch below seems to do the trick for me:
> 

fsck_ffs already has a -R flag to automatically retry, wouldn't that be
a better mechanism for handling this new type of retry?

-- Ian