From owner-freebsd-fs@FreeBSD.ORG Thu Feb 28 08:33:26 2008 Return-Path: Delivered-To: freebsd-fs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 16FCB1065670; Thu, 28 Feb 2008 08:33:26 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from falcon.cybervisiontech.com (falcon.cybervisiontech.com [217.20.163.9]) by mx1.freebsd.org (Postfix) with ESMTP id AEDAC8FC28; Thu, 28 Feb 2008 08:33:25 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from localhost (localhost [127.0.0.1]) by falcon.cybervisiontech.com (Postfix) with ESMTP id BA70B74400E; Thu, 28 Feb 2008 10:33:24 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at falcon.cybervisiontech.com Received: from falcon.cybervisiontech.com ([127.0.0.1]) by localhost (falcon.cybervisiontech.com [127.0.0.1]) (amavisd-new, port 10027) with ESMTP id 0PAqPK9BJGFv; Thu, 28 Feb 2008 10:33:24 +0200 (EET) Received: from [91.193.172.111] (unknown [91.193.172.111]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by falcon.cybervisiontech.com (Postfix) with ESMTP id 6CF3474400D; Thu, 28 Feb 2008 10:33:23 +0200 (EET) Message-ID: <47C671CF.9020101@icyb.net.ua> Date: Thu, 28 Feb 2008 10:33:19 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.9 (X11/20071208) MIME-Version: 1.0 To: pav@FreeBSD.org References: <200612221824.kBMIOhfM049471@freefall.freebsd.org> <47A2EDB0.8000801@icyb.net.ua> <47A2F404.7010208@icyb.net.ua> <47A735A4.3060506@icyb.net.ua> <47A75B47.2040604@elischer.org> <1202155663.62432.0.camel@ikaros.oook.cz> <47A8754C.5010607@icyb.net.ua> <1202235368.68281.12.camel@ikaros.oook.cz> <1204053786.1799.0.camel@ikaros.oook.cz> In-Reply-To: <1204053786.1799.0.camel@ikaros.oook.cz> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 8bit Cc: Bruce Evans , freebsd-hackers@FreeBSD.org, scottl@FreeBSD.org, freebsd-fs@FreeBSD.org, Julian Elischer , Remko Lodder Subject: Re: fs/udf: vm pages "overlap" while reading large dir [patch] X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2008 08:33:26 -0000 on 26/02/2008 21:23 Pav Lucistnik said the following: > Pav Lucistnik píše v út 05. 02. 2008 v 19:16 +0100: >> Andriy Gapon píše v út 05. 02. 2008 v 16:40 +0200: >> >>>> Yay, and can you fix the sequential read performance while you're at it? >>>> Kthx! >>> this was almost trivial :-) >>> See the attached patch, first hunk is just for consistency. >>> The code was borrowed from cd9660, only field/variable names are adjusted. > > Just tested it with my shiny new Bluray drive, and it work wonders. > Finally seamless playback of media files off UDF carrying media. > > So, how does it look WRT committing it? > Pav, thank you for the feedback/reminder. In my personal option the latest patch posted and described at the following like is a very good candidate for commit: http://docs.FreeBSD.org/cgi/mid.cgi?47AA43B9.1040608 It might have a couple of style related issues, but it should improve things a bit even if some larger VM/VFS/GEOM issues remain. And by the way, a patch from the following PR would be a good "side-dish" for the above patch: http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/78987 I think it is simple and obvious enough. -- Andriy Gapon