From owner-freebsd-bugs@FreeBSD.ORG Thu Feb 2 14:50:05 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 298BB106564A for ; Thu, 2 Feb 2012 14:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D476C8FC0A for ; Thu, 2 Feb 2012 14:50:04 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q12Eo45b003773 for ; Thu, 2 Feb 2012 14:50:04 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q12Eo4K9003772; Thu, 2 Feb 2012 14:50:04 GMT (envelope-from gnats) Resent-Date: Thu, 2 Feb 2012 14:50:04 GMT Resent-Message-Id: <201202021450.q12Eo4K9003772@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Garrett Cooper Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 499831065670 for ; Thu, 2 Feb 2012 14:45:49 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 3462E8FC16 for ; Thu, 2 Feb 2012 14:45:49 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id q12Ejnm0087844 for ; Thu, 2 Feb 2012 14:45:49 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id q12EjmsK087843; Thu, 2 Feb 2012 14:45:48 GMT (envelope-from nobody) Message-Id: <201202021445.q12EjmsK087843@red.freebsd.org> Date: Thu, 2 Feb 2012 14:45:48 GMT From: Garrett Cooper To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: conf/164709: [patch] [pc-sysinstall] add raidz3 support; permit 'raidz' in input X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Feb 2012 14:50:05 -0000 >Number: 164709 >Category: conf >Synopsis: [patch] [pc-sysinstall] add raidz3 support; permit 'raidz' in input >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Feb 02 14:50:04 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9.0-STABLE >Organization: n/a >Environment: FreeBSD bayonetta.local 9.0-STABLE FreeBSD 9.0-STABLE #4 r230371M: Thu Jan 19 23:55:38 PST 2012 gcooper@bayonetta.local:/usr/obj/store/freebsd/stable/9/sys/BAYONETTA amd64 >Description: The attached patch permits one to specify raidz3 in get_fs_line_xvars(..) (RAIDZ3 is 3-disk parity option available in versions of ZFS in 8.3+/9.0+), and also relaxes the checks to allow one to specify raidz instead of raidz1. >How-To-Repeat: >Fix: Patch attached with submission follows: Index: usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh =================================================================== --- usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh (revision 230088) +++ usr.sbin/pc-sysinstall/backend/functions-bsdlabel.sh (working copy) @@ -59,7 +59,7 @@ ZTYPE="NONE" ZFSVARS="`echo $LINE | cut -d '(' -f 2- | cut -d ')' -f 1 | xargs`" - echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz(1|2)?|spare|log|cache):" 2>/dev/null + echo $ZFSVARS | grep -qE "^(disk|file|mirror|raidz[1-3]?|spare|log|cache):" 2>/dev/null if [ $? -eq 0 ] ; then ZTYPE=`echo $ZFSVARS | cut -f1 -d:` ZFSVARS=`echo $ZFSVARS | sed "s|$ZTYPE: ||g" | sed "s|$ZTYPE:||g"` >Release-Note: >Audit-Trail: >Unformatted: