From owner-cvs-all@FreeBSD.ORG Wed Jun 23 18:06:17 2004 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EF71016A4CE for ; Wed, 23 Jun 2004 18:06:17 +0000 (GMT) Received: from mail4.speakeasy.net (mail4.speakeasy.net [216.254.0.204]) by mx1.FreeBSD.org (Postfix) with ESMTP id C945643D5C for ; Wed, 23 Jun 2004 18:06:17 +0000 (GMT) (envelope-from jhb@FreeBSD.org) Received: (qmail 27369 invoked from network); 23 Jun 2004 18:06:17 -0000 Received: from dsl027-160-063.atl1.dsl.speakeasy.net (HELO server.baldwin.cx) ([216.27.160.63]) (envelope-sender ) encrypted SMTP for ; 23 Jun 2004 18:06:17 -0000 Received: from 10.50.41.233 (gw1.twc.weather.com [216.133.140.1]) by server.baldwin.cx (8.12.11/8.12.11) with ESMTP id i5NI6Dif065538; Wed, 23 Jun 2004 14:06:13 -0400 (EDT) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: cvs-all@FreeBSD.org Date: Wed, 23 Jun 2004 14:07:15 -0400 User-Agent: KMail/1.6 References: <200406231721.i5NHL2iJ087209@repoman.freebsd.org> In-Reply-To: <200406231721.i5NHL2iJ087209@repoman.freebsd.org> MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Message-Id: <200406231407.15459.jhb@FreeBSD.org> X-Spam-Checker-Version: SpamAssassin 2.63 (2004-01-11) on server.baldwin.cx cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpi.c acpi_pcib.c acpi_resource.c acpivar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2004 18:06:18 -0000 On Wednesday 23 June 2004 01:21 pm, John Baldwin wrote: > jhb 2004-06-23 17:21:02 UTC > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpi.c acpi_pcib.c acpi_resource.c > acpivar.h > Log: > - Defer BUS_CONFIG_INTR() on ACPI IRQ resources until the resources are > actually used. For most ACPI devices this means deferring the call > until bus_alloc_resource(). > - Add a function acpi_config_intr() to call BUS_CONFIG_INTR() for an > ACPI IRQ resource using the trigger mode and polarity information > stored in the ACPI resource object. > - Add a function acpi_lookup_irq_resource() to lookup the ACPI IRQ > resource that corresponds to a specified rid and new-bus resource. > - Have the ACPI PCI bridge driver call BUS_CONFIG_INTR() on interrupts > that it routes through link devices. > - Remove needactivate variable from acpi_alloc_resource() by changing the > function not modify the flags variable but just mask off RF_ACTIVE when > calling rman_reserve_resource(). > > Reviewed by: njl (1, an earlier version) These changes prevent BUS_CONFIG_INTR() being called on the IRQ resources for PCI link devices that aren't used or for it being called on the PIC resource when the link device hasn't been reprogrammed to use an appropriate APIC resource. This should get rid of any 'atpic: Ignoring invalid level/low configuration' bootverbose messages. It also allows us to enable bus_config_intr() when using APICs which should fix problems with various people's boxes. -- John Baldwin <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve" = http://www.FreeBSD.org