From owner-freebsd-stable@freebsd.org Mon Oct 22 14:29:46 2018 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9041EFFDF1F for ; Mon, 22 Oct 2018 14:29:46 +0000 (UTC) (envelope-from agapon@gmail.com) Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E8ED27C644; Mon, 22 Oct 2018 14:29:45 +0000 (UTC) (envelope-from agapon@gmail.com) Received: by mail-lf1-f66.google.com with SMTP id c24-v6so4085636lfi.12; Mon, 22 Oct 2018 07:29:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=C2/0kb/xlwDAT4Ifndnjm11+iHYTMsqi1iQHC51tcuY=; b=l7pLGXlPq7a8HArBABDcp6iJt8hYYzCRaU0DQJdwKIV1nT1UTGimoGcG31Ofw9IhLC HTtDho/TnvJE7plgfenPvCJtgI32q0Mbc0JM7a25SxGFGayKevKfT6TG7/sMEcHGaE2f cNNqqX8MVDfc0gnL0Ys6xk51jK+FobbFr8JzSGzYYn0ZpvcUYZXTBVMkxXO7XBr2K4ux A859qaOSqY6RfFZt7BjOrv8ee10Y4MuxncoteZKoljtyY4vQ9KgmVU0IwG5MHpDDSG5W TTlLyfWfhEMxTZM8fGps72QvuCPmZPyeiUl8ZWqUnu3bKwdXi2XFXVIxCeoUc2gnIa3s n4/Q== X-Gm-Message-State: ABuFfohVLVSCsG6iSf43OAdmUqGQit1fmW/0uGG5k1+gsJbBqQAbDyhy GhAfNV4E3fHZ/OaqRSPGEAux6aTj X-Google-Smtp-Source: ACcGV60nqgdK6dFfM54vSanjS7o7ElPZ7Es3foqkiUSEII0bZ37p7YYI6QE9hkWo7AVwrmwe/csgsg== X-Received: by 2002:a19:c203:: with SMTP id l3mr4214016lfc.113.1540218105862; Mon, 22 Oct 2018 07:21:45 -0700 (PDT) Received: from [192.168.0.88] (east.meadow.volia.net. [93.72.151.96]) by smtp.googlemail.com with ESMTPSA id n192-v6sm1388451lfn.0.2018.10.22.07.21.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Oct 2018 07:21:44 -0700 (PDT) Subject: Re: krpc: unbootable ZFS-on-root after major upgrade to 11.2 To: Glen Barber , Eugene Grosbein Cc: FreeBSD stable References: <8517429b-9e3b-2ea3-80a6-12fc92106252@grosbein.net> <6627d159-fd52-2d10-2d45-97fd02725adc@FreeBSD.org> <5BC9A2E4.9010306@grosbein.net> <6c2f8adb-c0e7-550b-8595-e7a4768d5157@FreeBSD.org> <20181022140304.GE13668@FreeBSD.org> <1d5236b8-0269-5dce-3f2e-e7b1910836c6@grosbein.net> <20181022141527.GF13668@FreeBSD.org> From: Andriy Gapon Openpgp: preference=signencrypt Autocrypt: addr=avg@FreeBSD.org; prefer-encrypt=mutual; keydata= xsFNBFm4LIgBEADNB/3lT7f15UKeQ52xCFQx/GqHkSxEdVyLFZTmY3KyNPQGBtyvVyBfprJ7 mAeXZWfhat6cKNRAGZcL5EmewdQuUfQfBdYmKjbw3a9GFDsDNuhDA2QwFt8BmkiVMRYyvI7l N0eVzszWCUgdc3qqM6qqcgBaqsVmJluwpvwp4ZBXmch5BgDDDb1MPO8AZ2QZfIQmplkj8Y6Z AiNMknkmgaekIINSJX8IzRzKD5WwMsin70psE8dpL/iBsA2cpJGzWMObVTtCxeDKlBCNqM1i gTXta1ukdUT7JgLEFZk9ceYQQMJJtUwzWu1UHfZn0Fs29HTqawfWPSZVbulbrnu5q55R4PlQ /xURkWQUTyDpqUvb4JK371zhepXiXDwrrpnyyZABm3SFLkk2bHlheeKU6Yql4pcmSVym1AS4 dV8y0oHAfdlSCF6tpOPf2+K9nW1CFA8b/tw4oJBTtfZ1kxXOMdyZU5fiG7xb1qDgpQKgHUX8 7Rd2T1UVLVeuhYlXNw2F+a2ucY+cMoqz3LtpksUiBppJhw099gEXehcN2JbUZ2TueJdt1FdS ztnZmsHUXLxrRBtGwqnFL7GSd6snpGIKuuL305iaOGODbb9c7ne1JqBbkw1wh8ci6vvwGlzx rexzimRaBzJxlkjNfMx8WpCvYebGMydNoeEtkWldtjTNVsUAtQARAQABzR5BbmRyaXkgR2Fw b24gPGF2Z0BGcmVlQlNELm9yZz7CwZQEEwEIAD4WIQS+LEO7ngQnXA4Bjr538m7TUc1yjwUC WbgsiAIbIwUJBaOagAULCQgHAgYVCAkKCwIEFgIDAQIeAQIXgAAKCRB38m7TUc1yj+JAEACV l9AK/nOWAt/9cufV2fRj0hdOqB1aCshtSrwHk/exXsDa4/FkmegxXQGY+3GWX3deIyesbVRL rYdtdK0dqJyT1SBqXK1h3/at9rxr9GQA6KWOxTjUFURsU7ok/6SIlm8uLRPNKO+yq0GDjgaO LzN+xykuBA0FlhQAXJnpZLcVfPJdWv7sSHGedL5ln8P8rxR+XnmsA5TUaaPcbhTB+mG+iKFj GghASDSfGqLWFPBlX/fpXikBDZ1gvOr8nyMY9nXhgfXpq3B6QCRYKPy58ChrZ5weeJZ29b7/ QdEO8NFNWHjSD9meiLdWQaqo9Y7uUxN3wySc/YUZxtS0bhAd8zJdNPsJYG8sXgKjeBQMVGuT eCAJFEYJqbwWvIXMfVWop4+O4xB+z2YE3jAbG/9tB/GSnQdVSj3G8MS80iLS58frnt+RSEw/ psahrfh0dh6SFHttE049xYiC+cM8J27Aaf0i9RflyITq57NuJm+AHJoU9SQUkIF0nc6lfA+o JRiyRlHZHKoRQkIg4aiKaZSWjQYRl5Txl0IZUP1dSWMX4s3XTMurC/pnja45dge/4ESOtJ9R 8XuIWg45Oq6MeIWdjKddGhRj3OohsltKgkEU3eLKYtB6qRTQypHHUawCXz88uYt5e3w4V16H lCpSTZV/EVHnNe45FVBlvK7k7HFfDDkryM7BTQRZuCyIARAAlq0slcsVboY/+IUJdcbEiJRW be9HKVz4SUchq0z9MZPX/0dcnvz/gkyYA+OuM78dNS7Mbby5dTvOqfpLJfCuhaNYOhlE0wY+ 1T6Tf1f4c/uA3U/YiadukQ3+6TJuYGAdRZD5EqYFIkreARTVWg87N9g0fT9BEqLw9lJtEGDY EWUE7L++B8o4uu3LQFEYxcrb4K/WKmgtmFcm77s0IKDrfcX4doV92QTIpLiRxcOmCC/OCYuO jB1oaaqXQzZrCutXRK0L5XN1Y1PYjIrEzHMIXmCDlLYnpFkK+itlXwlE2ZQxkfMruCWdQXye syl2fynAe8hvp7Mms9qU2r2K9EcJiR5N1t1C2/kTKNUhcRv7Yd/vwusK7BqJbhlng5ZgRx0m WxdntU/JLEntz3QBsBsWM9Y9wf2V4tLv6/DuDBta781RsCB/UrU2zNuOEkSixlUiHxw1dccI 6CVlaWkkJBxmHX22GdDFrcjvwMNIbbyfQLuBq6IOh8nvu9vuItup7qemDG3Ms6TVwA7BD3j+ 3fGprtyW8Fd/RR2bW2+LWkMrqHffAr6Y6V3h5kd2G9Q8ZWpEJk+LG6Mk3fhZhmCnHhDu6CwN MeUvxXDVO+fqc3JjFm5OxhmfVeJKrbCEUJyM8ESWLoNHLqjywdZga4Q7P12g8DUQ1mRxYg/L HgZY3zfKOqcAEQEAAcLBfAQYAQgAJhYhBL4sQ7ueBCdcDgGOvnfybtNRzXKPBQJZuCyIAhsM BQkFo5qAAAoJEHfybtNRzXKPBVwQAKfFy9P7N3OsLDMB56A4Kf+ZT+d5cIx0Yiaf4n6w7m3i ImHHHk9FIetI4Xe54a2IXh4Bq5UkAGY0667eIs+Z1Ea6I2i27Sdo7DxGwq09Qnm/Y65ADvXs 3aBvokCcm7FsM1wky395m8xUos1681oV5oxgqeRI8/76qy0hD9WR65UW+HQgZRIcIjSel9vR XDaD2HLGPTTGr7u4v00UeTMs6qvPsa2PJagogrKY8RXdFtXvweQFz78NbXhluwix2Tb9ETPk LIpDrtzV73CaE2aqBG/KrboXT2C67BgFtnk7T7Y7iKq4/XvEdDWscz2wws91BOXuMMd4c/c4 OmGW9m3RBLufFrOag1q5yUS9QbFfyqL6dftJP3Zq/xe+mr7sbWbhPVCQFrH3r26mpmy841ym dwQnNcsbIGiBASBSKksOvIDYKa2Wy8htPmWFTEOPRpFXdGQ27awcjjnB42nngyCK5ukZDHi6 w0qK5DNQQCkiweevCIC6wc3p67jl1EMFY5+z+zdTPb3h7LeVnGqW0qBQl99vVFgzLxchKcl0 R/paSFgwqXCZhAKMuUHncJuynDOP7z5LirUeFI8qsBAJi1rXpQoLJTVcW72swZ42IdPiboqx NbTMiNOiE36GqMcTPfKylCbF45JNX4nF9ElM0E+Y8gi4cizJYBRr2FBJgay0b9Cp Message-ID: Date: Mon, 22 Oct 2018 17:21:43 +0300 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20181022141527.GF13668@FreeBSD.org> Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Oct 2018 14:29:46 -0000 On 22/10/2018 17:15, Glen Barber wrote: > On Mon, Oct 22, 2018 at 09:09:14PM +0700, Eugene Grosbein wrote: >> 22.10.2018 21:03, Glen Barber wrote: >> >> t's strange that this is a 10.x vs 11.x issue. >>>>> I see that zfs has the krpc dependency since r193128. >>>>> And the call to xdrmem_create is there since r168404. >>>> >>>> You are right. I was mis-informed and have not verified enough a report from local user. >>>> >>>> Glen, maybe that errata record should be deleted. The problem is real but it is long-standing >>>> and present in 10.x too. >>>> >>> >>> Could you elaborate more on the failure case you originally reported >>> first? If the problem is real, my feeling is that the errata entry >>> should stay, just worded differently to reflect the failure case here. >> >> zfs.ko depends on krpc.ko. The KRPC code in compiled in GENERIC kernel as dependency >> of NFS client/server code. The problem arises if all of these are true: >> >> 1) a system uses custom kernel with NFS options removed; >> 2) there is no krpc.ko available due to MODULES_OVERRIDE excluding it; >> 3) the system boots off ZFS pool. >> >> In such case, loader cannot resolve dependency and fails to load zfs.ko >> and kernel fails to mount root breaking boot sequence. >> >> > > So, if I understand correctly (and please correct me if I am wrong), the > majority of the text in the errata note is correct, however needs to be > tweaked to remove "upgrading from 10.x...". Is this generally correct? This is just a typical foot-shooting (and a shortcoming of the kernel build system that allows such foot-shooting to happen). I think that there can be other ways in which you can specify inconsistent kernel options and/or an incorrect subset of modules in MODULES_OVERRIDE to create missing dependencies for critical modules. Do we want to issue an errata for each possible misconfiguration? -- Andriy Gapon