From owner-p4-projects@FreeBSD.ORG  Sat Jul 26 10:49:14 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 6AFF8106567E; Sat, 26 Jul 2008 10:49:14 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2DC751065678
	for <perforce@FreeBSD.org>; Sat, 26 Jul 2008 10:49:14 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 1F4EC8FC08
	for <perforce@FreeBSD.org>; Sat, 26 Jul 2008 10:49:14 +0000 (UTC)
	(envelope-from ed@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.2/8.14.2) with ESMTP id m6QAnEEX067024
	for <perforce@FreeBSD.org>; Sat, 26 Jul 2008 10:49:14 GMT
	(envelope-from ed@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m6QAnEIh067022
	for perforce@freebsd.org; Sat, 26 Jul 2008 10:49:14 GMT
	(envelope-from ed@FreeBSD.org)
Date: Sat, 26 Jul 2008 10:49:14 GMT
Message-Id: <200807261049.m6QAnEIh067022@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	ed@FreeBSD.org using -f
From: Ed Schouten <ed@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 145959 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 26 Jul 2008 10:49:14 -0000

http://perforce.freebsd.org/chv.cgi?CH=145959

Change 145959 by ed@ed_dull on 2008/07/26 10:48:18

	I think we want to call finit() at the bottom. I don't want to
	know the strange things that could happen when the descriptor
	would be closed, while we're still creating the device node in
	make_dev().

Affected files ...

.. //depot/projects/mpsafetty/sys/dev/pts/pts.c#5 edit

Differences ...

==== //depot/projects/mpsafetty/sys/dev/pts/pts.c#5 (text+ko) ====

@@ -532,11 +532,11 @@
 
 	tp = tty_alloc(&pts_class, psc, NULL);
 
-	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
-
 	/* Expose the slave device as well */
 	tty_makedev(tp, td->td_ucred, "pts/%u", psc->pts_unit);
 
+	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
+
 	return (0);
 }
 
@@ -559,10 +559,10 @@
 
 	tp = tty_alloc(&pts_class, psc, NULL);
 
-	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
-
 	/* Expose the slave device as well */
 	tty_makedev(tp, td->td_ucred, "%s", name);
+
+	finit(fp, fflags, DTYPE_PTS, tp, &ptsdev_ops);
 }
 #endif /* PTS_EXTERNAL */